From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
David Miller <davem@davemloft.net>,
shemminger@vyatta.com, jarkao2@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] netpoll: fix race on poll_list resulting in garbage entry
Date: Fri, 19 Dec 2008 00:30:03 +0100 [thread overview]
Message-ID: <1229643003.3601.58.camel@johannes.berg> (raw)
In-Reply-To: <1229640015.2914.20.camel@hashbaz.i.decadent.org.uk> (sfid-20081219_002215_896671_C1B9AA7B)
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On Thu, 2008-12-18 at 22:40 +0000, Ben Hutchings wrote:
> > if (rx_packets < budget) {
> > /* There is no race here; although napi_disable() will
> > - * only wait for netif_rx_complete(), this isn't a problem
> > + * only wait for netif_rx_complete(this isn't a problem
> > * since efx_channel_processed() will have no effect if
> > * interrupts have already been disabled.
> > */
> [...]
>
> You'll want to exclude comments from your search-and-replace.
Or just use spatch (http://www.emn.fr/x-info/coccinelle/)
Should be as easy as:
@@
expression A, B;
@@
-netif_rx_schedule(A, B);
+netif_rx_schedule(B);
etc.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-12-18 23:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 21:06 [PATCH] netpoll: fix race on poll_list resulting in garbage entry Neil Horman
2008-12-10 7:22 ` David Miller
2008-12-11 13:07 ` Jarek Poplawski
2008-12-11 14:29 ` Neil Horman
2008-12-11 17:01 ` Stephen Hemminger
2008-12-11 18:15 ` Neil Horman
2008-12-12 0:03 ` Stephen Hemminger
2008-12-12 12:18 ` Neil Horman
2008-12-16 23:55 ` David Miller
2008-12-17 21:16 ` Neil Horman
2008-12-17 21:31 ` Stephen Hemminger
2008-12-17 23:44 ` Neil Horman
2008-12-18 1:13 ` Neil Horman
2008-12-18 3:29 ` David Miller
2008-12-18 14:47 ` Neil Horman
2008-12-18 19:52 ` Neil Horman
2008-12-18 22:40 ` Ben Hutchings
2008-12-18 23:30 ` Johannes Berg [this message]
2008-12-19 1:25 ` Neil Horman
2008-12-19 6:42 ` David Miller
2008-12-19 13:42 ` Neil Horman
2008-12-23 4:43 ` David Miller
2008-12-18 9:04 ` Jarek Poplawski
2008-12-12 7:07 ` Jarek Poplawski
2008-12-12 13:31 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229643003.3601.58.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).