From: "Alex G." <mr.nuke.me@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
keith.busch@intel.com, alex_gagniuc@dellteam.com,
austin_bolen@dell.com, shyam_iyer@dell.com,
Ariel Elior <ariel.elior@cavium.com>,
everest-linux-l2@cavium.com,
"David S. Miller" <davem@davemloft.net>,
Michael Chan <michael.chan@broadcom.com>,
Ganesh Goudar <ganeshgr@chelsio.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org,
oss-drivers@netronome.com
Subject: Re: [PATCH 1/9] PCI: sysfs: Export available PCIe bandwidth
Date: Wed, 5 Sep 2018 08:52:31 -0500 [thread overview]
Message-ID: <122e86e4-7c0a-8539-75dc-1515c1b8c68f@gmail.com> (raw)
In-Reply-To: <20180905082605.69d9e5a0@shemminger-XPS-13-9360>
On 09/05/2018 02:26 AM, Stephen Hemminger wrote:
> On Mon, 3 Sep 2018 13:02:28 -0500
> Alexandru Gagniuc <mr.nuke.me@gmail.com> wrote:
>
>> For certain bandwidth-critical devices (e.g. multi-port network cards)
>> it is useful to know the available bandwidth to the root complex. This
>> information is only available via the system log, which doesn't
>> account for link degradation after probing.
>>
>> With a sysfs attribute, we can computes the bandwidth on-demand, and
>> will detect degraded links.
>>
>> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
>
> In other places (like /sys/class/net/eth0/speed) only the raw value is printed
> without suffix. The general convention in sysfs is that it should be one value
> per file and in more raw format. So why not just print it in bits/sec without
> suffix?
I wanted to be consistent with other PCIe exports that use units.For
example:
/sys/devices/pci0000:3a/0000:3a:00.0/0000:3b:00.0/0000:3c:05.0/max_link_speed:8
GT/s
/sys/devices/pci0000:3a/0000:3a:00.0/0000:3b:00.0/0000:3c:05.0/current_link_speed:2.5
GT/s
/sys/bus/pci/slots/182/cur_bus_speed:2.5 GT/s PCIe
/sys/bus/pci/slots/182/max_bus_speed:8.0 GT/s PCIe
next prev parent reply other threads:[~2018-09-05 13:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 18:02 [PATCH 0/9] Export PCIe bandwidth via sysfs Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 1/9] PCI: sysfs: Export available PCIe bandwidth Alexandru Gagniuc
2018-09-05 7:26 ` Stephen Hemminger
2018-09-05 13:52 ` Alex G. [this message]
2018-10-03 21:30 ` Bjorn Helgaas
2018-10-03 22:00 ` Alex_Gagniuc
2018-10-04 20:45 ` Bjorn Helgaas
2018-10-08 21:09 ` Alex_Gagniuc
2018-09-03 18:02 ` [PATCH 2/9] bnx2x: Do not call pcie_print_link_status() Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 3/9] bnxt_en: " Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 4/9] cxgb4: " Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 5/9] fm10k: " Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 6/9] ixgbe: " Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 7/9] net/mlx4: " Alexandru Gagniuc
2018-09-04 12:51 ` Leon Romanovsky
2018-09-03 18:02 ` [PATCH 8/9] net/mlx5: " Alexandru Gagniuc
2018-09-04 12:51 ` Leon Romanovsky
2018-09-03 18:02 ` [PATCH 9/9] nfp: " Alexandru Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=122e86e4-7c0a-8539-75dc-1515c1b8c68f@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=ariel.elior@cavium.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=everest-linux-l2@cavium.com \
--cc=ganeshgr@chelsio.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub.kicinski@netronome.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=keith.busch@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=saeedm@mellanox.com \
--cc=shyam_iyer@dell.com \
--cc=stephen@networkplumber.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).