From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jeff@garzik.org,
Alexander Duyck <alexander.h.duyck@intel.com>
Subject: Re: [NET-NEXT PATCH 1/2] igb: defeature tx head writeback
Date: Wed, 24 Dec 2008 15:18:29 -0800 [thread overview]
Message-ID: <1230160709.9847.10.camel@localhost> (raw)
In-Reply-To: <20081224223142.12176.9916.stgit@lost.foo-projects.org>
On Wed, 2008-12-24 at 14:31 -0800, Jeff Kirsher wrote:
> diff --git a/drivers/net/igb/igb.h b/drivers/net/igb/igb.h
> index 2121b8b..c906325 100644
> --- a/drivers/net/igb/igb.h
> +++ b/drivers/net/igb/igb.h
[]
> @@ -127,7 +125,8 @@ struct igb_buffer {
> /* TX */
> struct {
> unsigned long time_stamp;
> - u32 length;
> + u16 length;
> + u16 next_to_watch;
> };
> /* RX */
> struct {
struct igb_buffer {
struct sk_buff *skb;
dma_addr_t dma;
union {
/* TX */
struct {
unsigned long time_stamp;
u32 length;
};
/* RX */
struct {
struct page *page;
u64 page_dma;
unsigned int page_offset;
};
};
};
anonymous unions with anonymous structs?
That's not used very often in kernel source.
Should it be used here?
next prev parent reply other threads:[~2008-12-24 23:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 22:31 [NET-NEXT PATCH 1/2] igb: defeature tx head writeback Jeff Kirsher
2008-12-24 22:32 ` [NET-NEXT PATCH 2/2] igb: re-order queues to support cleaner use of ivar on 82576 Jeff Kirsher
2008-12-26 9:34 ` David Miller
2008-12-24 23:18 ` Joe Perches [this message]
2008-12-26 9:33 ` [NET-NEXT PATCH 1/2] igb: defeature tx head writeback David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230160709.9847.10.camel@localhost \
--to=joe@perches.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).