From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: sfr@canb.auug.org.au, tklein@de.ibm.com, netdev@vger.kernel.org,
raisch@de.ibm.com, themann@de.ibm.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] net/ehea: use consistent type
Date: Wed, 31 Dec 2008 20:09:01 +1100 [thread overview]
Message-ID: <1230714541.15389.69.camel@pasglop> (raw)
In-Reply-To: <20081230.215101.228854586.davem@davemloft.net>
On Tue, 2008-12-30 at 21:51 -0800, David Miller wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 31 Dec 2008 14:17:30 +1100
>
> > ehea_plpar_hcall9() takes an unsigned long array, so pass that.
> >
> > This change will avoid some warnings when we change u64 to unsigned
> > long long.
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Patch rejected, for the same reasons as the other driver
> change.
>
> We're not going to poop up some drivers with the assumption that long
> is 64-bit.
Well, in that case, this patch is actually correct without considering
the u64 change. The array is what lands in the registers of the pHyp
call, so strictly speaking, it's an array of unsigned long's (ie, 32-bit
on a 32-bit platform, 64-bit on a 64-bit platform), not an array of
u64's. This function being a wrapper on that pHyp call, it may as well
use the right type.
Cheers,
Ben.
next prev parent reply other threads:[~2008-12-31 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 3:17 [PATCH] net/ehea: use consistent type Stephen Rothwell
2008-12-31 5:51 ` David Miller
2008-12-31 9:09 ` Benjamin Herrenschmidt [this message]
2009-01-06 0:05 ` Stephen Rothwell
2009-01-06 0:19 ` David Miller
2009-01-06 5:34 ` [PATCH] net/ehea: use consistant type Stephen Rothwell
2009-01-06 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230714541.15389.69.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=raisch@de.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).