netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
	Neil Horman <nhorman@tuxdriver.com>,
	shemminger@vyatta.com, jarkao2@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Remove redundant NAPI functions
Date: Thu, 08 Jan 2009 12:40:46 -0800	[thread overview]
Message-ID: <1231447246.1739.61.camel@localhost> (raw)
In-Reply-To: <1231446610.3893.17.camel@achroite>

On Thu, 2009-01-08 at 20:30 +0000, Ben Hutchings wrote:
> Following the removal of the unused struct net_device * parameter from
> the NAPI functions named *netif_rx_* in commit 908a7a1, they are
> exactly equivalent to the corresponding *napi_* functions and are
> therefore redundant.

[]

> I revisited this to update the out-of-tree version of the sfc driver.
> This makes the *netif_rx_* functions equivalent to the corresponding
> *napi_* functions.  So let's finish the job.  This is another search-
> and-replace, mostly compile-tested.

napi was just new-api.
Why persist what seems a poor naming choice?



  reply	other threads:[~2009-01-08 20:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08 20:30 [PATCH] net: Remove redundant NAPI functions Ben Hutchings
2009-01-08 20:40 ` Joe Perches [this message]
2009-01-08 20:54   ` David Miller
2009-01-09 14:58 ` Neil Horman
2009-01-10  7:06 ` David Miller
2009-01-12  7:13 ` Jarek Poplawski
2009-01-12 14:09   ` Ben Hutchings
2009-01-12 14:46     ` Ben Hutchings
2009-01-12 17:31       ` Krzysztof Halasa
2009-01-13  0:30         ` David Miller
2009-01-13  1:35           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231447246.1739.61.camel@localhost \
    --to=joe@perches.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).