From: Andy King <acking@vmware.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
gregkh@linuxfoundation.org, davem@davemloft.net
Subject: Re: [Pv-drivers] [PATCH 0/1] VM Sockets for Linux upstreaming
Date: Wed, 6 Feb 2013 16:32:30 -0800 (PST) [thread overview]
Message-ID: <1231523602.1815949.1360197150398.JavaMail.root@vmware.com> (raw)
In-Reply-To: <1315741351.2964541.1360083749055.JavaMail.root@vmware.com>
Hi Gerd,
> > linux/vmw_vmci_defs.h: No such file or directory
> > compilation terminated.
> > make[4]: *** [net/vmw_vsock/af_vsock.o] Error 1
>
> Oops, you're right, it really shouldn't need that header. Sorry
> about that, let me rip that out.
Fixed. The VMCI headers are now gone from the core in af_vsock.*
and vsock_addr.*
> > Only vmw_vsock_vmci_transport should have a vmw_vmci dependency,
> > not vsock ...
>
> Agreed, that's not right, I'll fix that too.
Fixed, lsmod now shows that only the transport has a dependency.
Also, it turns out that we do need a dgram_recv(), since our
transport currently enqueues skbs with VMCI DGRAMs in them, which
need to be converted before copying into the user's buffer. I've
added that too.
Please see latest patchset (sent a few minutes ago), hope it works
for you this time.
Thanks!
- Andy
next prev parent reply other threads:[~2013-02-07 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 23:26 [PATCH 0/1] VM Sockets for Linux upstreaming Andy King
2013-02-04 23:26 ` [PATCH 1/1] VSOCK: Introduce VM Sockets Andy King
2013-02-05 16:41 ` [PATCH 0/1] VM Sockets for Linux upstreaming Gerd Hoffmann
2013-02-05 17:02 ` Andy King
2013-02-07 0:32 ` Andy King [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-07 0:23 Andy King
2013-02-09 1:20 ` [Pv-drivers] " Dmitry Torokhov
2013-02-09 2:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231523602.1815949.1360197150398.JavaMail.root@vmware.com \
--to=acking@vmware.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).