From: Harvey Harrison <harvey.harrison@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: rdreier@cisco.com, netdev@vger.kernel.org
Subject: Re: Some NIPQUAD_FMT -> %pI4 conversions are broken
Date: Fri, 09 Jan 2009 22:24:20 -0800 [thread overview]
Message-ID: <1231568660.5714.23.camel@brick> (raw)
In-Reply-To: <20090109.221554.190779821.davem@davemloft.net>
On Fri, 2009-01-09 at 22:15 -0800, David Miller wrote:
> From: Harvey Harrison <harvey.harrison@gmail.com>
> Date: Fri, 09 Jan 2009 22:07:25 -0800
>
> > My apologies indeed, the best choice I think is to add a temp var
> > for now and I'll work with you to eliminate the byteswapping further
> > up the callchain so a be32 gets passed down, but that might be too
> > involved for 2.6.29.
>
> Alternatively we could provide a %p* variant that took
> cpu endian addresses.
>
> I don't know how useful that would be, generally.
I don't think we want that, it would be better to just start work on the
nes drivers to work directly on be32s throughout, and eject all of the
byteswapping throughout the driver.
Having such a %p helper for host-endian just encourages more drivers to
be written the same way.
Harvey
next prev parent reply other threads:[~2009-01-10 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 3:47 Some NIPQUAD_FMT -> %pI4 conversions are broken Roland Dreier
2009-01-10 6:07 ` Harvey Harrison
2009-01-10 6:15 ` David Miller
2009-01-10 6:24 ` Harvey Harrison [this message]
2009-01-10 6:24 ` [PATCH] nes: fix reversed IP address Harvey Harrison
2009-01-10 6:49 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231568660.5714.23.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).