From: David Woodhouse <dwmw2@infradead.org>
To: Valdis.Kletnieks@vt.edu
Cc: David Miller <davem@davemloft.net>,
alessandro.suardi@gmail.com, jaswinderlinux@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok)
Date: Mon, 12 Jan 2009 08:13:59 +0000 [thread overview]
Message-ID: <1231748039.25018.1277.camel@macbook.infradead.org> (raw)
In-Reply-To: <4407.1231719036@turing-police.cc.vt.edu>
On Sun, 2009-01-11 at 19:10 -0500, Valdis.Kletnieks@vt.edu wrote:
> So it looks like the patch is failing to finish initialization of the card.
> Damned if *I* can see what's breaking it, the conversion to use a helper
> function tg3_request_firmware seems sane enough....
Ahem...
--- drivers/net/tg3.c.stupiddwmw2 2009-01-12 08:13:05.000000000 +0000
+++ drivers/net/tg3.c 2009-01-12 08:13:09.000000000 +0000
@@ -13151,7 +13151,7 @@ static int __devinit tg3_init_one(struct
try again in tg3_open(). So if you have the driver built
into the kernel, you can still get the firmware loaded
after userspace is running, when the device comes up. */
- if (err != -ENOENT)
+ if (err && err != -ENOENT)
goto err_out_fw;
}
--
dwmw2
next prev parent reply other threads:[~2009-01-12 8:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5a4c581d0901070624t6e769966t6b034b14d4732bd@mail.gmail.com>
2009-01-08 4:03 ` 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok) Alessandro Suardi
2009-01-08 6:12 ` Jaswinder Singh Rajput
2009-01-08 20:33 ` Alessandro Suardi
2009-01-08 20:53 ` David Miller
2009-01-09 17:30 ` Alessandro Suardi
2009-01-09 22:04 ` David Miller
2009-01-09 22:29 ` Alessandro Suardi
2009-01-11 11:10 ` Valdis.Kletnieks
2009-01-11 12:08 ` David Miller
2009-01-11 12:24 ` David Woodhouse
2009-01-11 12:59 ` David Woodhouse
2009-01-11 16:42 ` Alessandro Suardi
2009-01-11 16:53 ` David Woodhouse
2009-01-11 19:24 ` Alessandro Suardi
2009-01-11 19:26 ` David Woodhouse
2009-01-11 16:48 ` Valdis.Kletnieks
2009-01-11 16:56 ` David Woodhouse
2009-01-11 21:49 ` David Miller
2009-01-11 22:29 ` Valdis.Kletnieks
2009-01-11 22:46 ` David Woodhouse
2009-01-11 21:41 ` David Miller
2009-01-12 0:10 ` Valdis.Kletnieks
2009-01-12 1:39 ` Valdis.Kletnieks
2009-01-12 8:13 ` David Woodhouse [this message]
2009-01-13 4:46 ` Valdis.Kletnieks
2009-01-13 5:52 ` Valdis.Kletnieks
2009-01-11 21:39 ` David Miller
2009-01-11 22:02 ` David Woodhouse
2009-01-11 22:05 ` David Miller
2009-01-11 22:41 ` David Woodhouse
2009-01-13 6:13 ` Willy Tarreau
2009-01-11 22:15 ` David Woodhouse
2009-01-11 22:19 ` David Miller
2009-01-13 18:39 ` Matt Carlson
2009-01-13 20:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231748039.25018.1277.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alessandro.suardi@gmail.com \
--cc=davem@davemloft.net \
--cc=jaswinderlinux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).