From: Cesar Eduardo Barros <cesarb@cesarb.net>
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, Cesar Eduardo Barros <cesarb@cesarb.net>
Subject: [PATCH 4/5] sc92031: use device id directly instead of made-up name
Date: Mon, 12 Jan 2009 21:21:50 -0200 [thread overview]
Message-ID: <1231802511-14825-4-git-send-email-cesarb@cesarb.net> (raw)
In-Reply-To: <496BD04F.2050502@cesarb.net>
Instead of making up a name for the device ids, put them directly in the
device id table. Also move the vendor id to pci_ids.h.
Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
---
drivers/net/sc92031.c | 8 ++------
include/linux/pci_ids.h | 2 ++
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
index ac4ccd4..2a111f2 100644
--- a/drivers/net/sc92031.c
+++ b/drivers/net/sc92031.c
@@ -31,10 +31,6 @@
#include <asm/irq.h>
-#define PCI_VENDOR_ID_SILAN 0x1904
-#define PCI_DEVICE_ID_SILAN_SC92031 0x2031
-#define PCI_DEVICE_ID_SILAN_8139D 0x8139
-
#define SC92031_NAME "sc92031"
/* BAR 0 is MMIO, BAR 1 is PIO */
@@ -1591,8 +1587,8 @@ out:
}
static struct pci_device_id sc92031_pci_device_id_table[] __devinitdata = {
- { PCI_DEVICE(PCI_VENDOR_ID_SILAN, PCI_DEVICE_ID_SILAN_SC92031) },
- { PCI_DEVICE(PCI_VENDOR_ID_SILAN, PCI_DEVICE_ID_SILAN_8139D) },
+ { PCI_DEVICE(PCI_VENDOR_ID_SILAN, 0x2031) },
+ { PCI_DEVICE(PCI_VENDOR_ID_SILAN, 0x8139) },
{ 0, }
};
MODULE_DEVICE_TABLE(pci, sc92031_pci_device_id_table);
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index d543365..c05bc2a 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2208,6 +2208,8 @@
#define PCI_VENDOR_ID_TOPSPIN 0x1867
+#define PCI_VENDOR_ID_SILAN 0x1904
+
#define PCI_VENDOR_ID_TDI 0x192E
#define PCI_DEVICE_ID_TDI_EHCI 0x0101
--
1.6.1.dirty
next prev parent reply other threads:[~2009-01-12 23:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 23:20 [PATCH 0/5] sc92031: trivial cosmetic fixes Cesar Eduardo Barros
2009-01-12 23:21 ` [PATCH 1/5] sc92031: more useful banner in kernel log Cesar Eduardo Barros
2009-01-12 23:21 ` [PATCH 2/5] sc92031: remove meaningless version string Cesar Eduardo Barros
2009-01-12 23:21 ` [PATCH 3/5] sc92031: inline SC92031_DESCRIPTION Cesar Eduardo Barros
2009-01-12 23:21 ` Cesar Eduardo Barros [this message]
2009-01-12 23:21 ` [PATCH 5/5] sc92031: add a link to the datasheet Cesar Eduardo Barros
2009-01-15 4:34 ` [PATCH 0/5] sc92031: trivial cosmetic fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231802511-14825-4-git-send-email-cesarb@cesarb.net \
--to=cesarb@cesarb.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).