From: "Eilon Greenstein" <eilong@broadcom.com>
To: "Ben Hutchings" <bhutchings@solarflare.com>
Cc: "David Miller" <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 10/34]bnx2x: Compilation issue on IA64
Date: Wed, 14 Jan 2009 19:44:33 +0200 [thread overview]
Message-ID: <1231955073.11301.161.camel@lb-tlvb-eliezer> (raw)
In-Reply-To: <1231952824.3010.29.camel@achroite>
On Wed, 2009-01-14 at 09:07 -0800, Ben Hutchings wrote:
> On Wed, 2009-01-14 at 18:43 +0200, Eilon Greenstein wrote:
> > Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
[...]
> > #ifdef BNX2X_STOP_ON_ERROR
> > fp->tpa_queue_used |= (1 << queue);
> > -#ifdef __powerpc64__
> > +#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
> > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
> > #else
> > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",
>
> Or you could cast the value to unsigned long long and remove this
> fragile #ifdef.
>
You are right - it is a better solution. The issue is that this uglier
solution is already in, and I hate to re-send this patch just for this.
Can we have this one applied and I will re visit it in net-next?
Eilon
next prev parent reply other threads:[~2009-01-14 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 16:43 [PATCH 10/34]bnx2x: Compilation issue on IA64 Eilon Greenstein
2009-01-14 17:07 ` Ben Hutchings
2009-01-14 17:44 ` Eilon Greenstein [this message]
2009-01-14 21:10 ` David Miller
2009-01-23 8:42 ` Eilon Greenstein
2009-01-26 2:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231955073.11301.161.camel@lb-tlvb-eliezer \
--to=eilong@broadcom.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox