netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "stanley.miao" <stanley.miao@windriver.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: netdev@vger.kernel.org, steve.glendinning@smsc.com,
	linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] smsc911x: add irq_flags in smsc911x_platform_config.
Date: Thu, 15 Jan 2009 10:16:54 +0800	[thread overview]
Message-ID: <1231985814.6810.15.camel@localhost> (raw)
In-Reply-To: <20090114170633.GG22976@n2100.arm.linux.org.uk>

On Wed, 2009-01-14 at 17:06 +0000, Russell King - ARM Linux wrote:
> On Wed, Jan 14, 2009 at 01:21:52PM +0800, Stanley.Miao wrote:
> > When calling request IRQ it is desirable to allow platforms
> > to specific flags for the call to request_irq. Adding irq_flags
> > to smsc911x_platform_config allows these flags to be passed.
> > 
> > Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
> > ---
> >  drivers/net/smsc911x.c   |    6 ++++--
> >  include/linux/smsc911x.h |    1 +
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
> > index f513bdf..1092517 100644
> > --- a/drivers/net/smsc911x.c
> > +++ b/drivers/net/smsc911x.c
> > @@ -1896,6 +1896,7 @@ static int __devinit smsc911x_drv_probe(struct platform_device *pdev)
> >  	unsigned int intcfg = 0;
> >  	int res_size;
> >  	int retval;
> > +	irq_flags;
> 
> This looks wrong.

Sorry, I have send the V2 version. I should send a notice to ignore this
email.

Stanley


      reply	other threads:[~2009-01-15  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14  5:21 [PATCH] smsc911x: add irq_flags in smsc911x_platform_config Stanley.Miao
2009-01-14 17:06 ` Russell King - ARM Linux
2009-01-15  2:16   ` stanley.miao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231985814.6810.15.camel@localhost \
    --to=stanley.miao@windriver.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux@arm.linux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=steve.glendinning@smsc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).