From: Harvey Harrison <harvey.harrison@gmail.com>
To: Eilon Greenstein <eilong@broadcom.com>
Cc: Christoph Hellwig <hch@infradead.org>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 11/34]bnx2x: Endianness issues
Date: Mon, 19 Jan 2009 11:54:38 -0800 [thread overview]
Message-ID: <1232394878.13386.1.camel@brick> (raw)
In-Reply-To: <1232360018.29087.3.camel@lb-tlvb-eliezer>
On Mon, 2009-01-19 at 12:13 +0200, Eilon Greenstein wrote:
> On Sun, 2009-01-18 at 08:59 -0800, Christoph Hellwig wrote:
> > On Wed, Jan 14, 2009 at 06:43:15PM +0200, Eilon Greenstein wrote:
> > > Adding missing le_to_cpu and disabling wrong HW endianity flag (the two complete
> > > each other)
> >
> > Did you run sparse over the driver to verify you've sorted out all
> > endianess issues?
> >
> No - those are errors with the FW/HW and not general issues. When
> running sparse with CF=-D__CHECK_ENDIAN__ I get "too many warnings"...
> So I cannot send the patch right now. I will definitely add it to my
> queue and I hope to sort it out soon.
>
> Eilon
I'll take a look as well. BTW, make sure you don't have the trace all
if statements tracer enabled in your config or you'll be drowned in
shadowed variable warnings and won't be able to see anything from your
driver.
Harvey
prev parent reply other threads:[~2009-01-19 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 16:43 [PATCH 11/34]bnx2x: Endianness issues Eilon Greenstein
2009-01-15 5:27 ` David Miller
2009-01-18 16:59 ` Christoph Hellwig
2009-01-19 10:13 ` Eilon Greenstein
2009-01-19 19:54 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232394878.13386.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=hch@infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).