* [PATCH] smsc95xx: fix function prototype of async callback
@ 2009-01-20 15:09 Steve Glendinning
2009-01-26 1:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Steve Glendinning @ 2009-01-20 15:09 UTC (permalink / raw)
To: netdev; +Cc: David Miller, Ian Saturley, Oliver Neukum, Steve Glendinning
smsc95xx_async_cmd_callback doesn't currently match usb_complete_t, so
there's a cast to force the square peg into the round hole. This patch
fixes this properly.
Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
---
drivers/net/usb/smsc95xx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 26fabef..5b0b964 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -306,7 +306,7 @@ static int smsc95xx_write_eeprom(struct usbnet *dev, u32 offset, u32 length,
return 0;
}
-static void smsc95xx_async_cmd_callback(struct urb *urb, struct pt_regs *regs)
+static void smsc95xx_async_cmd_callback(struct urb *urb)
{
struct usb_context *usb_context = urb->context;
struct usbnet *dev = usb_context->dev;
@@ -348,7 +348,7 @@ static int smsc95xx_write_reg_async(struct usbnet *dev, u16 index, u32 *data)
usb_fill_control_urb(urb, dev->udev, usb_sndctrlpipe(dev->udev, 0),
(void *)&usb_context->req, data, size,
- (usb_complete_t)smsc95xx_async_cmd_callback,
+ smsc95xx_async_cmd_callback,
(void *)usb_context);
status = usb_submit_urb(urb, GFP_ATOMIC);
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] smsc95xx: fix function prototype of async callback
2009-01-20 15:09 [PATCH] smsc95xx: fix function prototype of async callback Steve Glendinning
@ 2009-01-26 1:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-26 1:54 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev, ian.saturley, oliver
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Tue, 20 Jan 2009 15:09:00 +0000
> smsc95xx_async_cmd_callback doesn't currently match usb_complete_t, so
> there's a cast to force the square peg into the round hole. This patch
> fixes this properly.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-26 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-20 15:09 [PATCH] smsc95xx: fix function prototype of async callback Steve Glendinning
2009-01-26 1:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).