From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@elte.hu>,
Sam Ravnborg <sam@ravnborg.org>,
netdev@vger.kernel.org, davem@davemloft.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: why usr/include/linux/if_frad.h is required
Date: Wed, 21 Jan 2009 05:18:55 +0530 [thread overview]
Message-ID: <1232495335.3123.13.camel@localhost.localdomain> (raw)
In-Reply-To: <m3zlhlycso.fsf@intrepid.localdomain>
On Tue, 2009-01-20 at 20:53 +0100, Krzysztof Halasa wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > The CONFIG_DLCI check in there is clearly in error, the definition in there
> > is a user interface. The obvious solution is to drop the #if / #endif pair
> > without a replacement.
>
> I think so.
> OTOH I'd be really surprised if anyone on the planet still used this
> code/driver. IIRC and AFAICS it is (sdla.c coupled with dlci.c) the
> first driver for the old Sangoma ISA sync serial cards (S502 - S508,
> i.e. those based on Z80CPU doing HDLC and other things in firmware).
>
>
usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years
and no body is complaining about it so it means no body is using it.
So should we need to drop #if / #endif pair or the whole file from
userspace.
--
JSR
next prev parent reply other threads:[~2009-01-20 23:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 14:52 why usr/include/linux/if_frad.h is required Jaswinder Singh Rajput
2009-01-20 14:54 ` Jaswinder Singh Rajput
2009-01-20 17:47 ` Arnd Bergmann
2009-01-20 19:53 ` Krzysztof Halasa
2009-01-20 23:48 ` Jaswinder Singh Rajput [this message]
2009-01-21 1:06 ` Krzysztof Halasa
2009-01-21 4:50 ` Jaswinder Singh Rajput
2009-01-21 5:33 ` Sam Ravnborg
2009-01-21 6:15 ` David Miller
2009-01-21 6:38 ` Stephen Hemminger
2009-01-21 23:37 ` David Miller
2009-01-22 5:37 ` Sam Ravnborg
2009-01-24 13:25 ` Jaswinder Singh Rajput
2009-01-24 15:32 ` Krzysztof Halasa
2009-01-26 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232495335.3123.13.camel@localhost.localdomain \
--to=jaswinder@kernel.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).