From: "Eilon Greenstein" <eilong@broadcom.com>
To: "Harvey Harrison" <harvey.harrison@gmail.com>
Cc: linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 8/9] bnx2x: further annotations
Date: Thu, 22 Jan 2009 19:49:53 +0200 [thread overview]
Message-ID: <1232646594.29087.88.camel@lb-tlvb-eliezer> (raw)
In-Reply-To: <1232517051.9701.26.camel@brick>
On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> No functional annotations, just documenting the status quo.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
[...]
> @@ -9699,11 +9699,11 @@ static int bnx2x_start_xmit(struct sk_buff *skb, struct net_device *dev)
> bd_prod, ++nbd);
>
> pbd->lso_mss = cpu_to_le16(skb_shinfo(skb)->gso_size);
> - pbd->tcp_send_seq = swab32(tcp_hdr(skb)->seq);
> + pbd->tcp_send_seq = cpu_to_le32(be32_to_cpu(tcp_hdr(skb)->seq));
Hmmm.... That looks worse to me. Do we really need to replace swab with
cpu_to_le on top of be_to_cpu?
> pbd->tcp_flags = pbd_tcp_flags(skb);
>
> if (xmit_type & XMIT_GSO_V4) {
> - pbd->ip_id = swab16(ip_hdr(skb)->id);
> + pbd->ip_id = cpu_to_le16(be16_to_cpu(ip_hdr(skb)->id));
Same question
> pbd->tcp_pseudo_csum =
> swab16(~csum_tcpudp_magic(ip_hdr(skb)->saddr,
> ip_hdr(skb)->daddr,
next prev parent reply other threads:[~2009-01-22 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 5:50 [PATCH 8/9] bnx2x: further annotations Harvey Harrison
2009-01-22 17:49 ` Eilon Greenstein [this message]
2009-01-22 18:17 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232646594.29087.88.camel@lb-tlvb-eliezer \
--to=eilong@broadcom.com \
--cc=harvey.harrison@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox