From: Harvey Harrison <harvey.harrison@gmail.com>
To: Eilon Greenstein <eilong@broadcom.com>
Cc: linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 9/9] bnx2x: annotate nvram dword reading/writing
Date: Thu, 22 Jan 2009 10:18:42 -0800 [thread overview]
Message-ID: <1232648322.9701.55.camel@brick> (raw)
In-Reply-To: <1232646600.29087.90.camel@lb-tlvb-eliezer>
On Thu, 2009-01-22 at 19:50 +0200, Eilon Greenstein wrote:
> On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> > I believe this exposed an endian bug as the shifting of
> > bytes from the data buffer was done in cpu-order, then
> > masked into a be32 and the combined value was then converted
> > to cpu-order, this does all the masking in be-byteorder and
> > passes a cpu-ordered value to the write routine.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>
> This change is breaking the FW upgrade utility which uses this interface
> since it is changing the content. I will need to work with the engineer
> that owns this utility, but this change will probably stay out for a
> while
>
No worries, can you explain briefly what the code is trying to accomplish?
Maybe it was written assuming a le-machine, because this is going to
work differently on a be-machine.
Harvey
next prev parent reply other threads:[~2009-01-22 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 5:50 [PATCH 9/9] bnx2x: annotate nvram dword reading/writing Harvey Harrison
2009-01-22 17:50 ` Eilon Greenstein
2009-01-22 18:18 ` Harvey Harrison [this message]
2009-01-22 20:57 ` Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232648322.9701.55.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).