From: Patrick Ohly <patrick.ohly@intel.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
John Stultz <johnstul@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: clock synchronization utility code
Date: Wed, 4 Feb 2009 14:01:55 +0100 [thread overview]
Message-ID: <1233752517-30010-1-git-send-email-patrick.ohly@intel.com> (raw)
Hello!
These two patches are part of the larger patch series which adds
support for a hardware assisted implementation of the Precision Time
Protocol (PTP, IEEE 1588). They apply to net-next-2.6 as of a few days
ago, which itself was recently merged with v2.6.29-rc2.
It seems that we have reached a consensus how the networking
infrastructure needs to be changed; I have already adapted the patch
series accordingly. See the mail thread "hardware time stamping with
optional structs in data area" for details:
http://kerneltrap.org/mailarchive/linux-netdev/2009/1/21/4781774
We are less sure about these two patches because they are outside of
the network subsystem. The clocksource patch was already reviewed by
John and hasn't been changed since then. The second patch hasn't been
reviewed.
Both patches add code which is not called and has no effect unless a
driver developer decides to use this utility code. The larger patch
series contains patches to the igb driver which invoke the code. This
is how I tested it on 32 and 64 bit x86.
How should we proceed with these patches? David and I agree that it
would make sense to include them via the net-next-2.6 together with
the rest of the patch series. That way we ensure that no dead code
without users ends up in the kernel. Please let us know how we can
coordinate this so that friction between the subsystem trees is
minimized.
Diff summary:
include/linux/clocksource.h | 101 ++++++++++++++++++++++
include/linux/clocksync.h | 102 ++++++++++++++++++++++
kernel/time/Makefile | 2
kernel/time/clocksource.c | 77 ++++++++++++++++-
kernel/time/clocksync.c | 198 +++++++++++++++++++++++++++++++++++++++++++-
5 files changed, 477 insertions(+), 3 deletions(-)
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next reply other threads:[~2009-02-04 13:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 13:01 Patrick Ohly [this message]
2009-02-04 13:01 ` [PATCH NET-NEXT 01/10] clocksource: allow usage independent of timekeeping.c Patrick Ohly
2009-02-04 13:01 ` [PATCH NET-NEXT 02/10] time sync: generic infrastructure to map between time stamps generated by a time counter and system time Patrick Ohly
2009-02-04 19:44 ` john stultz
2009-02-05 10:21 ` Patrick Ohly
2009-02-09 17:02 ` Patrick Ohly
2009-02-09 19:27 ` John Stultz
2009-02-09 21:46 ` Patrick Ohly
2009-02-09 21:54 ` John Stultz
2009-02-09 22:57 ` David Miller
2009-02-04 14:03 ` [PATCH NET-NEXT 01/10] clocksource: allow usage independent of timekeeping.c Daniel Walker
2009-02-04 14:46 ` Patrick Ohly
2009-02-04 15:09 ` Daniel Walker
2009-02-04 15:24 ` Patrick Ohly
2009-02-04 19:25 ` john stultz
2009-02-04 19:40 ` Daniel Walker
2009-02-04 20:06 ` john stultz
2009-02-04 21:04 ` Daniel Walker
2009-02-04 21:15 ` john stultz
2009-02-05 0:18 ` Daniel Walker
2009-02-05 10:21 ` Patrick Ohly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233752517-30010-1-git-send-email-patrick.ohly@intel.com \
--to=patrick.ohly@intel.com \
--cc=davem@davemloft.net \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).