From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Parag Warudkar <parag.lkml@gmail.com>,
Matt Carlson <mcarlson@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: 2.6.29-rc3: tg3 dead after resume
Date: Sat, 07 Feb 2009 14:26:06 +1100 [thread overview]
Message-ID: <1233977166.31963.63.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.2.00.0901311450550.2978@localhost.localdomain>
>
> Here's a big hint: YOU DO NOT KNOW. YOU MUST NOT TURN OFF THE BRIDGE AT
> SUSPEND TIME!
A quick catch up on old emails ....
A good reason not to turn bridges off is that behind bridges, you'll
find more than your "normal" PCI devices. You'll find system devices,
things like your motherboard GPIO & clock control, i2c controllers,
service processors, your PIC, etc...
And your BIOS will need them. Your ACPI stuff will indirectly access
these things, for example to get the machine into actual suspend state
etc...
Disabling bridges is bad :-)
If they have to be disabled for power management purposes, then it's
likely that ACPI/BIOS itself will do it at the very last minute when
going into S3, and bring them back itself on the way back.
For embedded platforms who want to override that, they can always stick
a driver there or do it manually from a sysdev or platform code.
IE. I very very much doubt windows does anything to bridges, appart
-maybe- saving/restoring the standard window settings -just-in-case-
they got wiped out and the BIOS didn't restore them.
Ben.
next prev parent reply other threads:[~2009-02-07 3:26 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 0:14 2.6.29-rc3: tg3 dead after resume Parag Warudkar
2009-01-29 1:09 ` Linus Torvalds
2009-01-29 1:49 ` Parag Warudkar
2009-01-29 2:10 ` Linus Torvalds
2009-01-29 2:19 ` Matt Carlson
2009-01-29 22:22 ` Rafael J. Wysocki
2009-01-29 18:42 ` Matt Carlson
2009-01-29 22:06 ` Parag Warudkar
2009-01-29 22:22 ` Matt Carlson
2009-01-29 22:35 ` Parag Warudkar
2009-01-29 23:10 ` Rafael J. Wysocki
2009-01-30 18:40 ` Matt Carlson
2009-01-30 22:50 ` Parag Warudkar
2009-01-30 23:06 ` Linus Torvalds
2009-01-30 23:33 ` Linus Torvalds
2009-01-30 23:45 ` Parag Warudkar
2009-01-30 23:57 ` Linus Torvalds
2009-01-30 23:59 ` Rafael J. Wysocki
2009-01-31 0:28 ` Parag Warudkar
2009-01-31 0:38 ` Rafael J. Wysocki
2009-01-31 0:44 ` Ingo Molnar
2009-01-31 0:47 ` Rafael J. Wysocki
2009-01-31 1:21 ` Parag Warudkar
2009-01-31 1:37 ` Rafael J. Wysocki
2009-01-31 1:42 ` Parag Warudkar
2009-02-03 9:29 ` Rafael J. Wysocki
2009-02-03 21:27 ` Parag Warudkar
2009-02-03 22:15 ` Rafael J. Wysocki
2009-02-04 0:38 ` Parag Warudkar
2009-02-04 0:41 ` Rafael J. Wysocki
2009-02-07 3:00 ` Linus Torvalds
2009-02-07 18:03 ` Jesse Barnes
2009-01-31 1:46 ` Linus Torvalds
2009-01-31 1:54 ` Parag Warudkar
2009-01-31 2:25 ` Linus Torvalds
2009-01-31 2:40 ` Parag Warudkar
2009-01-31 18:51 ` Rafael J. Wysocki
2009-01-31 2:19 ` Linus Torvalds
2009-01-31 20:45 ` Rafael J. Wysocki
2009-01-31 1:41 ` Linus Torvalds
2009-01-31 21:08 ` Rafael J. Wysocki
2009-01-31 21:42 ` What should PCI core do during suspend-resume? (was: Re: 2.6.29-rc3: tg3 dead after resume) Rafael J. Wysocki
2009-01-31 21:59 ` Linus Torvalds
2009-01-31 23:08 ` Rafael J. Wysocki
2009-01-31 23:27 ` Linus Torvalds
2009-01-31 23:39 ` Linus Torvalds
2009-02-01 0:36 ` Rafael J. Wysocki
2009-02-01 1:06 ` Linus Torvalds
2009-02-01 1:13 ` Linus Torvalds
2009-02-01 1:20 ` Arjan van de Ven
2009-02-01 1:24 ` Rafael J. Wysocki
2009-02-07 9:21 ` Pavel Machek
2009-01-31 21:47 ` 2.6.29-rc3: tg3 dead after resume Linus Torvalds
2009-01-31 22:46 ` Rafael J. Wysocki
2009-01-31 23:01 ` Linus Torvalds
2009-02-01 0:11 ` Rafael J. Wysocki
2009-02-01 0:32 ` Linus Torvalds
2009-02-01 0:41 ` Rafael J. Wysocki
2009-02-01 0:51 ` Linus Torvalds
2009-02-07 3:27 ` Benjamin Herrenschmidt
2009-02-07 3:26 ` Benjamin Herrenschmidt [this message]
2009-01-29 23:03 ` Rafael J. Wysocki
2009-01-29 23:41 ` Matt Carlson
2009-01-30 0:10 ` Rafael J. Wysocki
2009-01-30 22:31 ` Parag Warudkar
2009-01-30 22:36 ` Linus Torvalds
2009-01-30 22:54 ` Rafael J. Wysocki
2009-01-30 23:07 ` Linus Torvalds
2009-01-30 23:13 ` Parag Warudkar
2009-01-30 23:31 ` Rafael J. Wysocki
2009-01-30 23:51 ` Linus Torvalds
2009-01-31 0:07 ` Rafael J. Wysocki
2009-01-31 0:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233977166.31963.63.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=parag.lkml@gmail.com \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).