From: "Michael Chan" <mchan@broadcom.com>
To: "Roel Kluin" <roel.kluin@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
mcarlson@broadcom.com
Subject: Re: [PATCH] TG3: limit reaches -1
Date: Wed, 11 Feb 2009 12:40:16 -0800 [thread overview]
Message-ID: <1234384817.14439.131.camel@HP1> (raw)
In-Reply-To: <4992AD3A.7000301@gmail.com>
On Wed, 2009-02-11 at 02:49 -0800, Roel Kluin wrote:
> With while (limit--) { ... } limit reaches -1, so 0 means success.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Michael Chan <mchan@broadcom.com>
Thanks.
> ---
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index 8b3f846..4595962 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -852,7 +852,7 @@ static int tg3_bmcr_reset(struct tg3 *tp)
> }
> udelay(10);
> }
> - if (limit <= 0)
> + if (limit < 0)
> return -EBUSY;
>
> return 0;
> @@ -1603,7 +1603,7 @@ static int tg3_wait_macro_done(struct tg3 *tp)
> break;
> }
> }
> - if (limit <= 0)
> + if (limit < 0)
> return -EBUSY;
>
> return 0;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-02-11 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 10:49 [PATCH] TG3: limit reaches -1 Roel Kluin
2009-02-11 20:40 ` Michael Chan [this message]
2009-02-13 0:33 ` David Miller
2009-02-15 22:17 ` [PATCH] TG3: &&/|| confusion Roel Kluin
2009-02-16 17:27 ` Michael Chan
2009-02-17 18:34 ` Matt Carlson
2009-02-19 1:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234384817.14439.131.camel@HP1 \
--to=mchan@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).