From: Ben Hutchings <bhutchings@solarflare.com>
To: Eilon Greenstein <eilong@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 03/41]bnx2x: MSI support
Date: Thu, 12 Feb 2009 18:52:38 +0000 [thread overview]
Message-ID: <1234464759.3583.8.camel@achroite> (raw)
In-Reply-To: <1234463775.1863.134.camel@lb-tlvb-eliezer>
On Thu, 2009-02-12 at 20:36 +0200, Eilon Greenstein wrote:
[...]
> diff --git a/drivers/net/bnx2x_reg.h b/drivers/net/bnx2x_reg.h
> index fc957fa..0be77c5 100644
> --- a/drivers/net/bnx2x_reg.h
> +++ b/drivers/net/bnx2x_reg.h
> @@ -745,6 +745,7 @@
> #define DORQ_REG_SHRT_CMHEAD 0x170054
> #define HC_CONFIG_0_REG_ATTN_BIT_EN_0 (0x1<<4)
> #define HC_CONFIG_0_REG_INT_LINE_EN_0 (0x1<<3)
> +#define HC_CONFIG_0_REG_MSI_ATTN_EN_0 (0x1<<7)
> #define HC_CONFIG_0_REG_MSI_MSIX_INT_EN_0 (0x1<<2)
> #define HC_CONFIG_0_REG_SINGLE_ISR_EN_0 (0x1<<1)
> #define HC_REG_AGG_INT_0 0x108050
> @@ -5359,9 +5360,28 @@
> #define PCICFG_PM_CSR_STATE (0x3<<0)
> #define PCICFG_PM_CSR_PME_ENABLE (1<<8)
> #define PCICFG_PM_CSR_PME_STATUS (1<<15)
> +#define PCICFG_MSI_CAP_ID 0x58
This appears to be a capability offset, not a capability id! You might
also consider not hard-coding it.
> +#define PCICFG_MSI_CONTROL_ENABLE (0x1<<16)
> +#define PCICFG_MSI_CONTROL_MCAP (0x7<<17)
> +#define PCICFG_MSI_CONTROL_MENA (0x7<<20)
> +#define PCICFG_MSI_CONTROL_64_BIT_ADDR_CAP (0x1<<23)
> +#define PCICFG_MSI_CONTROL_MSI_PVMASK_CAPABLE (0x1<<24)
> #define PCICFG_GRC_ADDRESS 0x78
> #define PCICFG_GRC_DATA 0x80
> +#define PCICFG_MSIX_CAP_ID 0xa0
[...]
Similarly for this.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-02-12 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 18:36 [PATCH 03/41]bnx2x: MSI support Eilon Greenstein
2009-02-12 18:52 ` Ben Hutchings [this message]
2009-02-12 20:37 ` Eilon Greenstein
2009-02-12 20:47 ` Ben Hutchings
2009-02-12 20:55 ` Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234464759.3583.8.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).