From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eilon Greenstein" Subject: Re: [PATCH 03/41]bnx2x: MSI support Date: Thu, 12 Feb 2009 22:55:42 +0200 Message-ID: <1234472142.4798.15.camel@lb-tlvb-eliezer> References: <1234463775.1863.134.camel@lb-tlvb-eliezer> <1234464759.3583.8.camel@achroite> <1234471059.4798.7.camel@lb-tlvb-eliezer> <1234471668.3583.26.camel@achroite> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "David Miller" , "netdev@vger.kernel.org" To: "Ben Hutchings" Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:4456 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbZBLUz5 (ORCPT ); Thu, 12 Feb 2009 15:55:57 -0500 In-Reply-To: <1234471668.3583.26.camel@achroite> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2009-02-12 at 12:47 -0800, Ben Hutchings wrote: > On Thu, 2009-02-12 at 22:37 +0200, Eilon Greenstein wrote: > > On Thu, 2009-02-12 at 10:52 -0800, Ben Hutchings wrote: > > Hi Ben! > > > > It's always a pleasure to see how fast you respond. I really appreciate > > the fact that you take the time to review my patches. Thanks! > > > > > On Thu, 2009-02-12 at 20:36 +0200, Eilon Greenstein wrote: > > > [...] > > > > @@ -5359,9 +5360,28 @@ > > > > #define PCICFG_PM_CSR_STATE (0x3<<0) > > > > #define PCICFG_PM_CSR_PME_ENABLE (1<<8) > > > > #define PCICFG_PM_CSR_PME_STATUS (1<<15) > > > > +#define PCICFG_MSI_CAP_ID 0x58 > > > > > > This appears to be a capability offset, not a capability id! You might > > > also consider not hard-coding it. > > > > You are right - those are the offset for this device. I find it easier to > > debug when I have the offsets at hand without the need to parse the > > capabilities linked list. Since the offsets will not change for this > > generation of chips, I don't see the harm in providing the explicit > > offsets. I assume that the driver will require major changes for a new > > generation even if I will use the capabilities ID... > > I agree, the run-time lookup is not really necessary. But please fix > the name. The name... Indeed it is misleading, I will fix it in the next patch (on top of this one) Eilon > Ben. >