From: Ben Hutchings <bhutchings@solarflare.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jeff@garzik.org,
gospo@redhat.com, Alexander Duyck <alexander.h.duyck@intel.com>
Subject: Re: [net-next PATCH 4/6] igb: misc cleanup to combine one if statement and set last_rx
Date: Fri, 13 Feb 2009 13:23:23 +0000 [thread overview]
Message-ID: <1234531403.3110.3.camel@achroite> (raw)
In-Reply-To: <20090213041804.3848.73723.stgit@lost.foo-projects.org>
On Thu, 2009-02-12 at 20:18 -0800, Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This patch combines a pair of if statements into one and adds a line to
> update netdev->last_rx.
[...]
You shouldn't need to update last_rx any more:
commit 6cf3f41e6c08bca6641a695449791c38a25f35ff
Author: Jay Vosburgh <fubar@us.ibm.com>
Date: Mon Nov 3 18:16:50 2008 -0800
bonding, net: Move last_rx update into bonding recv logic
The only user of the net_device->last_rx field is bonding.
This patch adds a conditional update of last_rx to the bonding special
logic in skb_bond_should_drop, causing last_rx to only be updated when
the ARP monitor is running.
This frees network device drivers from the necessity of
updating last_rx, which can have cache line thrash issues.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-02-13 13:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 4:16 [net-next PATCH 1/6] igb: misc whitespace/formatting cleanups Jeff Kirsher
2009-02-13 4:17 ` [net-next PATCH 2/6] igb: reduce size required to trigger low latency Jeff Kirsher
2009-02-16 8:06 ` David Miller
2009-02-13 4:17 ` [net-next PATCH 3/6] igb: cleanup incorrect comment and set IP Checksum Enable Jeff Kirsher
2009-02-16 8:06 ` David Miller
2009-02-13 4:18 ` [net-next PATCH 4/6] igb: misc cleanup to combine one if statement and set last_rx Jeff Kirsher
2009-02-13 13:23 ` Ben Hutchings [this message]
2009-02-14 5:43 ` David Miller
2009-02-13 4:18 ` [net-next PATCH 5/6] igb: remove unused defines Jeff Kirsher
2009-02-16 8:06 ` David Miller
2009-02-13 4:18 ` [net-next PATCH 6/6] igb: transition driver to only using advanced descriptors Jeff Kirsher
2009-02-16 8:07 ` David Miller
2009-02-16 8:06 ` [net-next PATCH 1/6] igb: misc whitespace/formatting cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234531403.3110.3.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).