Re: LRO restructuring?

[Ben Hutchings <bhutchings@solarflare.com>]

On Wed, 2009-02-18 at 19:25 +0000, James Huang wrote:
> Hi Herbert,
> 
>     Any idea when this LRO restructuring work will be done? 
> Making LRO available even when ip forwarding is enabled will significantly 
> improve performace of network appliances in the data path.  

Herbert has added "GRO" rather than immediately replacing the inet_lro
code.  An early version of this is in 2.6.29 and there is more in
net-next-2.6 destined for 2.6.30.

> I have some questions on this: 
[...]
> (3) I think bridged packets should not be LROed. Whether a packet is bridged 
> or not can be based on the L2 MAC destination address.  Is this how it is done?

GRO preserves enough information to reconstruct the original frames on
output, so there is no specific check for bridging.  Presumably it would
be cheaper not to do use GRO if the frames are not going to hit the
TCP/IP stack though.

> (4) Does LRO work only for IPv4?  Any plan to extend it to support IPv6?

IPv6 is covered.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.