From: Ben Hutchings <bhutchings@solarflare.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-net-drivers@solarflare.com, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sfc: mdio_clause45_read errors go unnoticed
Date: Fri, 27 Feb 2009 16:45:17 +0000 [thread overview]
Message-ID: <1235753117.3164.2.camel@achroite> (raw)
In-Reply-To: <49A81565.3030004@gmail.com>
On Fri, 2009-02-27 at 17:31 +0100, Roel Kluin wrote:
> This patch was not tested in any way, but:
>
> since commit 27dd2caca4eabe7c13a052b7456495ba75535e6a
> ------------------------------>8-------------8<---------------------------------
> mdio_clause45_read may return -ERR, but since 'devices' is unsigned, this is not
> noticed.
I already submitted a fix for this. I do need to resubmit it for
net-next-2.6 though. Thanks for the reminder.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2009-02-27 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 16:31 [PATCH] sfc: mdio_clause45_read errors go unnoticed Roel Kluin
2009-02-27 16:45 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235753117.3164.2.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).