From: David Dillow <dave@thedillows.org>
To: David Miller <davem@davemloft.net>
Cc: ben@decadent.org.uk, netdev@vger.kernel.org
Subject: Re: [PATCH v2] typhoon: Use request_firmware()
Date: Sun, 01 Mar 2009 22:16:47 -0500 [thread overview]
Message-ID: <1235963807.27973.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20090301.174433.258919971.davem@davemloft.net>
On Sun, 2009-03-01 at 17:44 -0800, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Mon, 02 Mar 2009 01:02:54 +0000
>
> > On Sun, 2009-03-01 at 15:38 -0500, David Dillow wrote:
> > > I suppose I better test this sooner rather than later, because I think
> > > you've broken it. The firmware gets vmalloc'd, which means it is not
> > > necessarily physically contiguous, and I don't think pci_map_single() is
> > > going to like that since the firmware is always larger than a page. But
> > > I may be wrong on this.
> >
> > You could well be right.
>
> He is definitely right, this cannot work.
Do you want to revert, or do you a patch to fix it? Revert will be
quicker as I have to dig out hardware to test...
next prev parent reply other threads:[~2009-03-02 3:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1235324217.2832.49.camel@hashbaz.i.decadent.org.uk>
2009-02-26 13:49 ` [PATCH v2] typhoon: Use request_firmware() Ben Hutchings
2009-02-27 7:21 ` David Miller
2009-03-01 20:38 ` David Dillow
2009-03-02 1:02 ` Ben Hutchings
2009-03-02 1:44 ` David Miller
2009-03-02 3:16 ` David Dillow [this message]
2009-03-02 4:11 ` David Miller
2009-03-02 4:29 ` David Miller
2009-03-02 7:56 ` David Dillow
2009-03-02 9:53 ` David Miller
2009-03-03 5:44 ` David Dillow
2009-03-03 5:49 ` [PATCH v3 checked] " David Dillow
2009-03-03 6:15 ` David Miller
[not found] ` <1235622381.8683.38.camel@hashbaz.i.decadent.org.uk>
2009-02-27 7:21 ` [PATCH v2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235963807.27973.1.camel@localhost.localdomain \
--to=dave@thedillows.org \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox