From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jesse.brandeburg@intel.com,
shemminger@vyatta.com
Subject: Re: [RFC v1] hand off skb list to other cpu to submit to upper layer
Date: Thu, 05 Mar 2009 09:04:36 +0800 [thread overview]
Message-ID: <1236215076.2567.105.camel@ymzhang> (raw)
In-Reply-To: <20090304.013937.129768263.davem@davemloft.net>
On Wed, 2009-03-04 at 01:39 -0800, David Miller wrote:
> From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
> Date: Wed, 04 Mar 2009 17:27:48 +0800
>
> > Both the new skb_record_rx_queue and current kernel have an
> > assumption on multi-queue. The assumption is it's best to send out
> > packets from the TX of the same number of queue like the one of RX
> > if the receved packets are related to the out packets. Or more
> > direct speaking is we need send packets on the same cpu on which we
> > receive them. The start point is that could reduce skb and data
> > cache miss.
>
> We have to use the same TX queue for all packets for the same
> connection flow (same src/dst IP address and ports) otherwise
> we introduce reordering.
> Herbert brought this up, now I have explicitly brought this up,
> and you cannot ignore this issue.
Thanks. Stephen Hemminger brought it up and explained what reorder
is. I answered in a reply (sorry for not clear) that mostly we need spread
packets among RX/TX in a 1:1 mapping or N:1 mapping. For example, all packets
received from RX 8 will be spreaded to TX 0 always.
>
> You must not knowingly reorder packets, and using different TX
> queues for packets within the same flow does that.
Thanks for you rexplanation which is really consistent with Stephen's speaking.
next prev parent reply other threads:[~2009-03-05 1:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 1:27 [RFC v1] hand off skb list to other cpu to submit to upper layer Zhang, Yanmin
2009-02-25 2:11 ` Stephen Hemminger
2009-02-25 2:35 ` Zhang, Yanmin
2009-02-25 5:18 ` Stephen Hemminger
2009-02-25 5:51 ` Zhang, Yanmin
2009-02-25 6:36 ` Herbert Xu
2009-02-25 7:20 ` Zhang, Yanmin
2009-02-25 7:31 ` David Miller
2009-03-04 9:27 ` Zhang, Yanmin
2009-03-04 9:39 ` David Miller
2009-03-05 1:04 ` Zhang, Yanmin [this message]
2009-03-05 2:40 ` Zhang, Yanmin
2009-03-05 7:32 ` Jens Låås
2009-03-05 9:24 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236215076.2567.105.camel@ymzhang \
--to=yanmin_zhang@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).