From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: yann.poupet@free.fr, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PROBLEM]: potential unaligned memory access in drivers/usb/gadget/rndis.c
Date: Thu, 12 Mar 2009 16:51:37 -0700 [thread overview]
Message-ID: <1236901897.4036.1.camel@brick> (raw)
In-Reply-To: <20090311235119.f4609775.akpm@linux-foundation.org>
On Wed, 2009-03-11 at 23:51 -0700, Andrew Morton wrote:
> Maybe the below fixed this? afacit it is queued for 2.6.30 in the
> net-next tree:
>
> commit 35c26c2cf6a6a2d1c48add732d8ba002bd90784c
> Author: Harvey Harrison <harvey.harrison@gmail.com>
> AuthorDate: Sat Feb 14 22:56:56 2009 -0800
> Commit: David S. Miller <davem@davemloft.net>
> CommitDate: Sat Feb 14 22:56:56 2009 -0800
>
> rndis: remove private wrapper of __constant_cpu_to_le32
>
> Use cpu_to_le32 directly as it handles constant folding now, replace direct
> uses of __constant_cpu_to_{endian} as well.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
Doubtful, this patch should be a no-op, any alignment problems that existed
before will still be there.
Harvey
next prev parent reply other threads:[~2009-03-12 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3848726.1723791236775868071.JavaMail.root@spooler2-g27.priv.proxad.net>
[not found] ` <3848726.1723791236775868071.JavaMail.root-u0VDug3vKOpsFmKuirFwRhh1pbbyJDp15NbjCUgZEJk@public.gmane.org>
2009-03-12 6:51 ` [PROBLEM]: potential unaligned memory access in drivers/usb/gadget/rndis.c Andrew Morton
2009-03-12 23:51 ` Harvey Harrison [this message]
2009-03-13 20:52 ` David Miller
[not found] ` <20090311235119.f4609775.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-03-16 8:38 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236901897.4036.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yann.poupet@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).