From: David Ahern <dsahern@gmail.com>
To: Stephen Suryaputra <ssuryaextr@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net] vrf: check the original netdevice for generating redirect
Date: Sun, 3 Jun 2018 09:31:00 -0600 [thread overview]
Message-ID: <1236e10c-7679-1bd4-58c5-cecd12dc41cc@gmail.com> (raw)
In-Reply-To: <1527825921-17677-1-git-send-email-ssuryaextr@gmail.com>
On 5/31/18 10:05 PM, Stephen Suryaputra wrote:
> Use the right device to determine if redirect should be sent especially
> when using vrf. Same as well as when sending the redirect.
>
> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
> ---
> net/ipv6/ip6_output.c | 3 ++-
> net/ipv6/ndisc.c | 6 ++++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
skb->dev in this path is set to the vrf device if applicable, so yes the
change is needed. Thanks for the fix.
Acked-by: David Ahern <dsahern@gmail.com>
prev parent reply other threads:[~2018-06-03 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 4:05 [PATCH net] vrf: check the original netdevice for generating redirect Stephen Suryaputra
2018-06-03 14:34 ` David Miller
2018-06-03 15:31 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236e10c-7679-1bd4-58c5-cecd12dc41cc@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).