From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] vrf: check the original netdevice for generating redirect Date: Sun, 3 Jun 2018 09:31:00 -0600 Message-ID: <1236e10c-7679-1bd4-58c5-cecd12dc41cc@gmail.com> References: <1527825921-17677-1-git-send-email-ssuryaextr@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Stephen Suryaputra , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:40461 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbeFCPbD (ORCPT ); Sun, 3 Jun 2018 11:31:03 -0400 Received: by mail-pf0-f194.google.com with SMTP id z24-v6so442458pfe.7 for ; Sun, 03 Jun 2018 08:31:03 -0700 (PDT) In-Reply-To: <1527825921-17677-1-git-send-email-ssuryaextr@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/31/18 10:05 PM, Stephen Suryaputra wrote: > Use the right device to determine if redirect should be sent especially > when using vrf. Same as well as when sending the redirect. > > Signed-off-by: Stephen Suryaputra > --- > net/ipv6/ip6_output.c | 3 ++- > net/ipv6/ndisc.c | 6 ++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) skb->dev in this path is set to the vrf device if applicable, so yes the change is needed. Thanks for the fix. Acked-by: David Ahern