[net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

[net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

[Ramkrishna Vepa]

- Kconfig and Makefile related changes for vxge driver.

Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com>
Signed-off-by: Rastapur Santosh <santosh.rastapur@neterion.com>
Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
---
diff -urpN patch_2/drivers/net/Kconfig patch_3/drivers/net/Kconfig
--- patch_2/drivers/net/Kconfig	2009-03-12 11:23:32.000000000 -0700
+++ patch_3/drivers/net/Kconfig	2009-03-12 11:33:06.000000000 -0700
@@ -2531,6 +2531,24 @@ config S2IO
 	  More specific information on configuring the driver is in 
 	  <file:Documentation/networking/s2io.txt>.

+config VXGE
+	tristate "Neterion X3100 Series 10GbE PCIe Server Adapter"
+	depends on PCI
+	select INET_LRO
+	---help---
+	  This driver supports Neterion Inc's X3100 Series 10 GbE PCIe
+	  I/O Virtualized Server Adapter.
+	  More specific information on configuring the driver is in
+	  <file:Documentation/networking/vxge.txt>.
+
+config VXGE_DEBUG_TRACE_ALL
+	bool "Enabling All Debug trace statments in driver"
+	default n
+	depends on VXGE
+	---help---
+	  Say Y here if you want to enabling all the debug trace statements in
+	  driver. By  default only few debug trace statements are enabled.
+
 config MYRI10GE
 	tristate "Myricom Myri-10G Ethernet support"
 	depends on PCI && INET
diff -urpN patch_2/drivers/net/Makefile patch_3/drivers/net/Makefile
--- patch_2/drivers/net/Makefile	2009-03-12 11:23:32.000000000 -0700
+++ patch_3/drivers/net/Makefile	2009-03-12 11:33:55.000000000 -0700
@@ -219,6 +219,7 @@ obj-$(CONFIG_R8169) += r8169.o
 obj-$(CONFIG_AMD8111_ETH) += amd8111e.o
 obj-$(CONFIG_IBMVETH) += ibmveth.o
 obj-$(CONFIG_S2IO) += s2io.o
+obj-$(CONFIG_VXGE) += vxge/
 obj-$(CONFIG_MYRI10GE) += myri10ge/
 obj-$(CONFIG_SMC91X) += smc91x.o
 obj-$(CONFIG_SMC911X) += smc911x.o
diff -urpN patch_2/drivers/net/vxge/Makefile patch_3/drivers/net/vxge/Makefile
--- patch_2/drivers/net/vxge/Makefile	1969-12-31 16:00:00.000000000 -0800
+++ patch_3/drivers/net/vxge/Makefile	2009-03-12 11:34:23.000000000 -0700
@@ -0,0 +1,9 @@
+#
+# Makefile for Neterion Inc's X3100 Series 10 GbE PCIe
+# I/O Virtualized Server Adapter linux driver
+#
+
+obj-$(CONFIG_VXGE) += vxge.o
+
+vxge-objs := vxge-config.o vxge-traffic.o vxge-ethtool.o vxge-main.o
+

Re: [net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

[Bill Fink]

On 14 Mar 2009, Ramkrishna Vepa wrote:

> - Kconfig and Makefile related changes for vxge driver.
> 
> Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com>
> Signed-off-by: Rastapur Santosh <santosh.rastapur@neterion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
> ---
> diff -urpN patch_2/drivers/net/Kconfig patch_3/drivers/net/Kconfig
> --- patch_2/drivers/net/Kconfig	2009-03-12 11:23:32.000000000 -0700
> +++ patch_3/drivers/net/Kconfig	2009-03-12 11:33:06.000000000 -0700
> @@ -2531,6 +2531,24 @@ config S2IO
>  	  More specific information on configuring the driver is in 
>  	  <file:Documentation/networking/s2io.txt>.
> 
> +config VXGE
> +	tristate "Neterion X3100 Series 10GbE PCIe Server Adapter"
> +	depends on PCI
> +	select INET_LRO
> +	---help---
> +	  This driver supports Neterion Inc's X3100 Series 10 GbE PCIe
> +	  I/O Virtualized Server Adapter.
> +	  More specific information on configuring the driver is in
> +	  <file:Documentation/networking/vxge.txt>.

To prevent certain build failures, when you "select INET_LRO" you also
need to add a depends on INET, so the above "depends on PCI" needs to
be changed to:

	depends on PCI && INET

						-Bill

Re: [net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

[Bill Fink]

On Sat, 14 Mar 2009, Bill Fink wrote:

> On 14 Mar 2009, Ramkrishna Vepa wrote:
> 
> > - Kconfig and Makefile related changes for vxge driver.
> > 
> > Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com>
> > Signed-off-by: Rastapur Santosh <santosh.rastapur@neterion.com>
> > Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
> > ---
> > diff -urpN patch_2/drivers/net/Kconfig patch_3/drivers/net/Kconfig
> > --- patch_2/drivers/net/Kconfig	2009-03-12 11:23:32.000000000 -0700
> > +++ patch_3/drivers/net/Kconfig	2009-03-12 11:33:06.000000000 -0700
> > @@ -2531,6 +2531,24 @@ config S2IO
> >  	  More specific information on configuring the driver is in 
> >  	  <file:Documentation/networking/s2io.txt>.
> > 
> > +config VXGE
> > +	tristate "Neterion X3100 Series 10GbE PCIe Server Adapter"
> > +	depends on PCI
> > +	select INET_LRO
> > +	---help---
> > +	  This driver supports Neterion Inc's X3100 Series 10 GbE PCIe
> > +	  I/O Virtualized Server Adapter.
> > +	  More specific information on configuring the driver is in
> > +	  <file:Documentation/networking/vxge.txt>.
> 
> To prevent certain build failures, when you "select INET_LRO" you also
> need to add a depends on INET, so the above "depends on PCI" needs to
> be changed to:
> 
> 	depends on PCI && INET

And I believe LRO has been deprecated in favor of GRO.

						-Bill

Re: [net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

[David Miller]

From: Bill Fink <billfink@mindspring.com>
Date: Sat, 14 Mar 2009 14:08:57 -0400

> And I believe LRO has been deprecated in favor of GRO.

That's correct.

We should not add any new users of LRO.

Re: [net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

[Ben Hutchings]

On Sat, 2009-03-14 at 00:20 -0800, Ramkrishna Vepa wrote:
> - Kconfig and Makefile related changes for vxge driver.
[...]

These should really come last in the series so they don't refer to
nonexistent files.  This may not matter for a new driver as Dave can
squash them together into one patch.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

RE: [net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

[Ramkrishna Vepa]

Ben,

Thanks for the comments. We will address them when we resubmit the
patches in the next day or so.

Ram

> -----Original Message-----
> From: netdev-owner@vger.kernel.org
[mailto:netdev-owner@vger.kernel.org]
> On Behalf Of Ben Hutchings
> Sent: Sunday, March 15, 2009 12:10 PM
> To: ram.vepa@neterion.com
> Cc: Netdev; David Miller
> Subject: Re: [net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and
> Makefile
> 
> On Sat, 2009-03-14 at 00:20 -0800, Ramkrishna Vepa wrote:
> > - Kconfig and Makefile related changes for vxge driver.
> [...]
> 
> These should really come last in the series so they don't refer to
> nonexistent files.  This may not matter for a new driver as Dave can
> squash them together into one patch.
> 
> Ben.
> 
> --
> Ben Hutchings, Senior Software Engineer, Solarflare Communications
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html