From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Igor Mitsyanko <imitsyanko@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>,
Sergey Matyukevich <smatyukevich@quantenna.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler
Date: Thu, 5 Apr 2018 11:33:15 -0500 [thread overview]
Message-ID: <123880c0-25f0-f53e-8c75-2a01c2756b4e@embeddedor.com> (raw)
In-Reply-To: <20180405163100.cuaedftds47pxdrn@bars>
Hi Sergey,
On 04/05/2018 11:31 AM, Sergey Matyukevich wrote:
> Hello Gustavo,
>
>> In case memory resources for fw were succesfully allocated, release
>> them before jumping to fw_load_fail.
>>
>> Addresses-Coverity-ID: 1466092 ("Resource leak")
>> Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> Thanks for the patch!
>
Glad to help. :)
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
>
Thanks
--
Gustavo
next prev parent reply other threads:[~2018-04-05 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 15:49 [PATCH] qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler Gustavo A. R. Silva
2018-04-05 16:31 ` Sergey Matyukevich
2018-04-05 16:33 ` Gustavo A. R. Silva [this message]
2018-04-25 8:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=123880c0-25f0-f53e-8c75-2a01c2756b4e@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=avinashp@quantenna.com \
--cc=imitsyanko@quantenna.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=smatyukevich@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).