public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Ed Swierk <eswierk@aristanetworks.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29)
Date: Mon, 06 Apr 2009 07:03:32 -0700	[thread overview]
Message-ID: <1239026612.23068.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20090404.165421.142076064.davem@davemloft.net>

On Sat, 2009-04-04 at 16:54 -0700, David Miller wrote:
> Please send a version of this patch that actually applies to
> Linus's tree, the line numbers et al. are a lot different
> now.
> 
> I'll backport and submit that to -stable.
> 
> Thanks.

Reset phy state on resume, fixing a regression caused by powering down
the phy on hibernate.

Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
---
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index a858c6f..663a7b3 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -6117,6 +6117,9 @@ static int nv_resume(struct pci_dev *pdev)
 
 	pci_write_config_dword(pdev, NV_MSI_PRIV_OFFSET, NV_MSI_PRIV_VALUE);
 
+	/* restore phy state, including autoneg */
+	phy_init(dev);
+
 	netif_device_attach(dev);
 	if (netif_running(dev)) {
 		rc = nv_open(dev);



  reply	other threads:[~2009-04-06 14:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-04 23:54 [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29) David Miller
2009-04-06 14:03 ` Ed Swierk [this message]
2009-04-07  0:49   ` [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation David Miller
     [not found] <200903261920.32173.tvrtko@ursulin.net>
     [not found] ` <200903270801.46712.tvrtko@ursulin.net>
     [not found]   ` <200903271255.36429.rjw@sisk.pl>
2009-03-27 20:09     ` [Regression in 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29) Rafael J. Wysocki
2009-03-29  8:03       ` Tvrtko A. Ursulin
2009-04-03 10:23         ` Tvrtko Ursulin
2009-04-03 15:24       ` Ed Swierk
2009-04-03 17:41         ` Ed Swierk
2009-04-03 20:26           ` Rafael J. Wysocki
2009-04-04 13:04           ` Tvrtko A. Ursulin
2009-04-04 13:07             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239026612.23068.1.camel@localhost.localdomain \
    --to=eswierk@aristanetworks.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox