netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: netdev@vger.kernel.org
Cc: Greg Ungerer <gerg@snapgear.com>, Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH 04/12] fec: remove unnecessary cast
Date: Wed, 15 Apr 2009 13:32:17 +0200	[thread overview]
Message-ID: <1239795145-27558-5-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1239795145-27558-4-git-send-email-s.hauer@pengutronix.de>

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/fec.c |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index fea8e27..3a43d96 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -1661,11 +1661,10 @@ int __init fec_enet_init(struct net_device *dev, int index)
 	struct bufdesc *bdp, *cbd_base;
 	int 		i, j;
 
-	/* Allocate memory for buffer descriptors.
-	*/
-	mem_addr = (unsigned long)dma_alloc_coherent(NULL, PAGE_SIZE,
-			&fep->bd_dma, GFP_KERNEL);
-	if (mem_addr == 0) {
+	/* Allocate memory for buffer descriptors. */
+	cbd_base = dma_alloc_coherent(NULL, PAGE_SIZE, &fep->bd_dma,
+			GFP_KERNEL);
+	if (!cbd_base) {
 		printk("FEC: allocate descriptor memory failed?\n");
 		return -ENOMEM;
 	}
@@ -1699,10 +1698,7 @@ int __init fec_enet_init(struct net_device *dev, int index)
 	}
 #endif
 
-	cbd_base = (struct bufdesc *)mem_addr;
-
-	/* Set receive and transmit descriptor base.
-	*/
+	/* Set receive and transmit descriptor base. */
 	fep->rx_bd_base = cbd_base;
 	fep->tx_bd_base = cbd_base + RX_RING_SIZE;
 
-- 
1.6.2.1


  reply	other threads:[~2009-04-15 11:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-15 11:32 [PATCH] FEC driver: patches for -next Sascha Hauer
2009-04-15 11:32 ` [PATCH 01/12] fec: remove unused ifdef Sascha Hauer
2009-04-15 11:32   ` [PATCH 02/12] fec: switch to writel/readl Sascha Hauer
2009-04-15 11:32     ` [PATCH 03/12] fec: do not typedef struct types Sascha Hauer
2009-04-15 11:32       ` Sascha Hauer [this message]
2009-04-15 11:32         ` [PATCH 05/12] fec: Codingstyle cleanups Sascha Hauer
2009-04-15 11:32           ` [PATCH 06/12] fec: refactor set_multicast_list() to make it more readable Sascha Hauer
2009-04-15 11:32             ` [PATCH 07/12] fec: refactor init function Sascha Hauer
2009-04-15 11:32               ` [PATCH 08/12] fec: align receive packets Sascha Hauer
2009-04-15 11:32                 ` [PATCH 09/12] fec: remove debugging printks Sascha Hauer
2009-04-15 11:32                   ` [PATCH 10/12] fec: switch to net_device_ops Sascha Hauer
2009-04-15 11:32                     ` [PATCH 11/12] FEC Buffer rework Sascha Hauer
2009-04-15 11:32                       ` [PATCH 12/12] fec: call fec_restart() in fec_open() Sascha Hauer
2009-04-16  9:38                         ` David Miller
2009-04-16  9:38                       ` [PATCH 11/12] FEC Buffer rework David Miller
2009-04-17 10:07                       ` Greg Ungerer
2009-04-17 10:12                         ` Sascha Hauer
2009-04-16  9:37                     ` [PATCH 10/12] fec: switch to net_device_ops David Miller
2009-04-16  9:37                   ` [PATCH 09/12] fec: remove debugging printks David Miller
2009-04-16  9:37                 ` [PATCH 08/12] fec: align receive packets David Miller
2009-04-16  9:37               ` [PATCH 07/12] fec: refactor init function David Miller
2009-04-16  9:37             ` [PATCH 06/12] fec: refactor set_multicast_list() to make it more readable David Miller
2009-04-16  9:36           ` [PATCH 05/12] fec: Codingstyle cleanups David Miller
2009-04-16  9:36         ` [PATCH 04/12] fec: remove unnecessary cast David Miller
2009-04-16  9:36       ` [PATCH 03/12] fec: do not typedef struct types David Miller
2009-04-15 13:11     ` [PATCH 02/12] fec: switch to writel/readl Sascha Hauer
2009-04-16  9:36       ` David Miller
2009-04-15 12:12 ` [PATCH] FEC driver: patches for -next Greg Ungerer
2009-04-15 12:55   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239795145-27558-5-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=gerg@snapgear.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).