From: Paul Smith <paul@mad-scientist.net>
To: Netdev <netdev@vger.kernel.org>
Subject: Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a second interface to my bond
Date: Wed, 15 Apr 2009 14:39:45 -0400 [thread overview]
Message-ID: <1239820785.8944.604.camel@psmith-ubeta.netezza.com> (raw)
In-Reply-To: <30789.1239819113@death.nxdomain.ibm.com>
On Wed, 2009-04-15 at 11:11 -0700, Jay Vosburgh wrote:
> The various MAC manipulating functions are either called under
> RTNL (as bond_alb_set_mac_address is) or take pains to acquire RTNL
> before doing anything with the MAC. Also, the slave list and
> curr_active_slave are mutexed by RTNL, so those inspections should be
> safe.
>
> I'm reasonably sure that the curr_slave_lock is superfluous
> (which wasn't the case when it was originally introduced), but I
> haven't had a chance to validate this. The locking has changed from
> what's documented in the header file; RTNL wasn't used for this when
> that was written.
OK, sounds good. I'll let you know if I observe any other odd behavior
with the bonding driver.
Thanks for the great support! Cheers!
--
Paul Smith <paul@mad-scientist.net>
next prev parent reply other threads:[~2009-04-15 18:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 21:15 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a second interface to my bond Paul Smith
2009-04-14 16:01 ` Paul Smith
2009-04-14 21:29 ` Brian Haley
2009-04-15 1:12 ` Jay Vosburgh
2009-04-15 3:23 ` David Miller
2009-04-15 5:29 ` Paul Smith
2009-04-15 16:56 ` Paul Smith
2009-04-15 18:11 ` Jay Vosburgh
2009-04-15 18:39 ` Paul Smith [this message]
[not found] ` <1241397581.6499.658.camel@homebase.localnet>
2009-05-04 19:03 ` 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying toifenslave " Jay Vosburgh
2009-05-04 19:06 ` David Miller
2009-05-04 22:38 ` Paul Smith
2009-05-04 22:44 ` David Miller
2009-05-05 0:59 ` Paul Smith
2009-05-04 23:00 ` 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" tryingtoifenslave " Jay Vosburgh
2009-05-04 23:04 ` David Miller
2009-05-04 23:05 ` 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying toifenslave " Ben Hutchings
2009-05-04 23:12 ` David Miller
2009-05-05 4:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239820785.8944.604.camel@psmith-ubeta.netezza.com \
--to=paul@mad-scientist.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).