From: Mark McLoughlin <markmc@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, jamesclhuang@gmail.com,
netdev@vger.kernel.org
Subject: Re: skb_segment() questions
Date: Mon, 20 Apr 2009 12:12:10 +0100 [thread overview]
Message-ID: <1240225930.23407.49.camel@blaa> (raw)
In-Reply-To: <20090330.135748.264670066.davem@davemloft.net>
On Mon, 2009-03-30 at 13:57 -0700, David Miller wrote:
> From: Mark McLoughlin <markmc@redhat.com>
> Date: Mon, 30 Mar 2009 09:50:45 +0100
>
> > On Sat, 2009-03-28 at 23:39 -0700, David Miller wrote:
> > > From: Herbert Xu <herbert@gondor.apana.org.au>
> > > Date: Sun, 29 Mar 2009 10:07:01 +0800
> > >
> > > > gso: Fix support for linear packets
> > > >
> > > > When GRO/frag_list support was added to GSO, I made an error
> > > > which broke the support for segmenting linear GSO packets (GSO
> > > > packets are normally non-linear in the payload).
> > > >
> > > > These days most of these packets are constructed by the tun
> > > > driver, which prefers to allocate linear memory if possible.
> > > > This is fixed in the latest kernel, but for 2.6.29 and earlier
> > > > it is still the norm.
> > > >
> > > > Therefore this bug causes failures with GSO when used with tun
> > > > in 2.6.29.
> > > >
> > > > Reported-by: James Huang <jamesclhuang@gmail.com>
> > > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> > >
> > > Applied, thanks.
> >
> > This is needed in -stable too, fwiw. Fixes e.g. virtio guest->remote
> > with 2.6.29 host:
> >
> > https://bugzilla.redhat.com/490266
>
> I know, I'll queue it up.
This hasn't made it yet? Just had another report on kvm list about it.
(Can't seem to find anywhere to check whether it's queued)
Cheers,
Mark.
next prev parent reply other threads:[~2009-04-20 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f0ed9b110903041912v6fba381fm4da792d49b1cbb91@mail.gmail.com>
2009-03-29 2:07 ` skb_segment() questions Herbert Xu
2009-03-29 6:39 ` David Miller
2009-03-30 8:50 ` Mark McLoughlin
2009-03-30 20:57 ` David Miller
2009-04-20 11:12 ` Mark McLoughlin [this message]
2009-04-20 11:57 ` David Miller
2009-04-01 9:18 ` [PATCH] " Jarek Poplawski
2009-04-01 9:24 ` Herbert Xu
2009-04-01 9:50 ` Jarek Poplawski
2009-04-01 9:53 ` Herbert Xu
2009-04-01 10:02 ` Jarek Poplawski
2009-03-05 0:08 James Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240225930.23407.49.camel@blaa \
--to=markmc@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jamesclhuang@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).