* [PATCH 7/8] tg3: Restore LAA sooner in shutdown sequence
@ 2009-04-20 16:58 Matt Carlson
2009-04-21 8:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Matt Carlson @ 2009-04-20 16:58 UTC (permalink / raw)
To: davem; +Cc: netdev, Michael Chan, Benjamin Li, andy
After a shutdown reset, the LAA needs to be restored before posting the
post-reset signature in shared memory. If the LAA is not restored
before then, the bootcode will assume the factory default MAC address
and WOL will not work with the LAA.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/tg3.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 0501fb4..f2b7ff8 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -2456,8 +2456,6 @@ static int tg3_set_power_state(struct tg3 *tp, pci_power_t state)
}
}
- __tg3_set_mac_addr(tp, 0);
-
if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) {
u32 val;
@@ -6357,6 +6355,8 @@ static int tg3_halt(struct tg3 *tp, int kind, int silent)
tg3_abort_hw(tp, silent);
err = tg3_chip_reset(tp);
+ __tg3_set_mac_addr(tp, 0);
+
tg3_write_sig_legacy(tp, kind);
tg3_write_sig_post_reset(tp, kind);
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 7/8] tg3: Restore LAA sooner in shutdown sequence
2009-04-20 16:58 [PATCH 7/8] tg3: Restore LAA sooner in shutdown sequence Matt Carlson
@ 2009-04-21 8:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-21 8:42 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, mchan, benli, andy
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Mon, 20 Apr 2009 09:58:52 -0700
> After a shutdown reset, the LAA needs to be restored before posting the
> post-reset signature in shared memory. If the LAA is not restored
> before then, the bootcode will assume the factory default MAC address
> and WOL will not work with the LAA.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-21 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-20 16:58 [PATCH 7/8] tg3: Restore LAA sooner in shutdown sequence Matt Carlson
2009-04-21 8:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).