From: "Michael Chan" <mchan@broadcom.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: "Eric Dumazet" <dada1@cosmosbay.com>,
"Christoph Lameter" <cl@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
"Linux Netdev List" <netdev@vger.kernel.org>,
"Ben Hutchings" <bhutchings@solarflare.com>
Subject: Re: about latencies
Date: Thu, 23 Apr 2009 16:01:06 -0700 [thread overview]
Message-ID: <1240527666.8857.8.camel@HP1> (raw)
In-Reply-To: <alpine.WNT.2.00.0904231520300.5352@jbrandeb-desk1.amr.corp.intel.com>
On Thu, 2009-04-23 at 15:34 -0700, Brandeburg, Jesse wrote:
> On Thu, 23 Apr 2009, Eric Dumazet wrote:
>
> > 3) changing bnx2_poll_work() to first call bnx2_rx_int(), then bnx2_tx_int() to consume tx.
>
> at least all of the intel drivers that have a single vector (function)
> handling interrupts, always call tx clean first so that any tx buffers are
> free to be used immediately because the NAPI calls can generate tx traffic
> (acks in the case of tcp and full routed packet transmits in the case of
> forwarding)
>
Are you talking about freeing the tx buffers in the tx ring to make room
for more tx packets? As long as the tx ring is not previously full and
is now completely free and idle, it doesn't matter too much when we free
the tx buffers in the tx ring, does it?
next prev parent reply other threads:[~2009-04-23 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 22:02 about latencies Eric Dumazet
2009-04-23 22:06 ` Christoph Lameter
2009-04-23 22:34 ` Brandeburg, Jesse
2009-04-23 23:01 ` Michael Chan [this message]
2009-04-23 23:07 ` Eric Dumazet
2009-04-24 0:04 ` David Miller
2009-04-24 5:11 ` Eric Dumazet
2009-04-24 14:00 ` Christoph Lameter
2009-04-24 14:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240527666.8857.8.camel@HP1 \
--to=mchan@broadcom.com \
--cc=bhutchings@solarflare.com \
--cc=cl@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).