* [PATCH net-next-2.6] pcnet32: Remove redundant set of skb->dev
@ 2009-04-24 19:48 John Dykstra
2009-04-27 9:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: John Dykstra @ 2009-04-24 19:48 UTC (permalink / raw)
To: netdev, pcnet32
Remove redundant set of skb->dev (now handled for ethernet
drivers by eth_type_trans()).
Signed-off-by: John Dykstra <john.dykstra1@gmail.com>
---
drivers/net/pcnet32.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
index 80124fa..e5e8c59 100644
--- a/drivers/net/pcnet32.c
+++ b/drivers/net/pcnet32.c
@@ -1227,7 +1227,6 @@ static void pcnet32_rx_entry(struct net_device *dev,
dev->stats.rx_dropped++;
return;
}
- skb->dev = dev;
if (!rx_in_place) {
skb_reserve(skb, NET_IP_ALIGN);
skb_put(skb, pkt_len); /* Make room */
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next-2.6] pcnet32: Remove redundant set of skb->dev
2009-04-24 19:48 [PATCH net-next-2.6] pcnet32: Remove redundant set of skb->dev John Dykstra
@ 2009-04-27 9:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-27 9:42 UTC (permalink / raw)
To: john.dykstra1; +Cc: netdev, pcnet32
From: John Dykstra <john.dykstra1@gmail.com>
Date: Fri, 24 Apr 2009 19:48:32 +0000
> Remove redundant set of skb->dev (now handled for ethernet
> drivers by eth_type_trans()).
>
> Signed-off-by: John Dykstra <john.dykstra1@gmail.com>
Applied, thanks John.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-27 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-24 19:48 [PATCH net-next-2.6] pcnet32: Remove redundant set of skb->dev John Dykstra
2009-04-27 9:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).