From: Jesper Dangaard Brouer <jdb@comx.dk>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH] sfc: Make temperature warnings/alarms more explicit.
Date: Tue, 28 Apr 2009 16:48:04 +0200 [thread overview]
Message-ID: <1240930084.10689.39.camel@localhost.localdomain> (raw)
In-Reply-To: <1240929844.10689.35.camel@localhost.localdomain>
The sfc driver can detect different hardware failures via the
LM87 system. One of the failures I have experienced is the
temperature alarm, but the error message didn't reveal that this
error was temperature related. I had to read the code to
discover that.
I think that the temperature error should be more explicit, in
order to warn people before the board is permanently damaged.
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---
drivers/net/sfc/boards.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sfc/boards.c b/drivers/net/sfc/boards.c
index 4a4c74c..b1822fe 100644
--- a/drivers/net/sfc/boards.c
+++ b/drivers/net/sfc/boards.c
@@ -121,8 +121,10 @@ static int efx_check_lm87(struct efx_nic *efx, unsigned mask)
if (alarms1 || alarms2) {
EFX_ERR(efx,
"LM87 detected a hardware failure (status %02x:%02x)"
- "%s%s\n",
+ "%s%s%s\n",
alarms1, alarms2,
+ (alarms1 & (LM87_ALARM_TEMP_INT|LM87_ALARM_TEMP_EXT1))
+ ? " high temperature" : "",
(alarms1 & LM87_ALARM_TEMP_INT) ? " INTERNAL" : "",
(alarms1 & LM87_ALARM_TEMP_EXT1) ? " EXTERNAL" : "");
return -ERANGE;
next prev parent reply other threads:[~2009-04-28 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 9:36 Driver SFC: Possible bug in LM87 temperature XFP detection code Jesper Dangaard Brouer
2009-04-28 13:36 ` Ben Hutchings
2009-04-28 14:44 ` Jesper Dangaard Brouer
2009-04-28 14:48 ` Jesper Dangaard Brouer [this message]
2009-04-30 0:50 ` [PATCH] sfc: Make temperature warnings/alarms more explicit David Miller
2009-04-30 1:25 ` Ben Hutchings
2009-04-30 8:44 ` Jesper Dangaard Brouer
2009-04-28 17:04 ` Driver SFC: Possible bug in LM87 temperature XFP detection code Ben Hutchings
2009-04-29 8:52 ` Jesper Dangaard Brouer
2009-04-29 12:11 ` Jesper Dangaard Brouer
2009-04-29 12:47 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240930084.10689.39.camel@localhost.localdomain \
--to=jdb@comx.dk \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).