From: "Eilon Greenstein" <eilong@broadcom.com>
To: "Ben Hutchings" <bhutchings@solarflare.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>,
"Yaniv Rosner" <yaniv.rosner@broadcom.com>
Subject: Re: [RFC] Add clause 45 ioctl
Date: Thu, 30 Apr 2009 18:05:59 +0300 [thread overview]
Message-ID: <1241103959.10391.3.camel@lb-tlvb-eliezer> (raw)
In-Reply-To: <1240924931.3200.3.camel@achroite>
On Tue, 2009-04-28 at 06:22 -0700, Ben Hutchings wrote:
> > I'm sending this as RFC - if anyone has alternative suggestions on how
> > user space application can access the PHY, I would appreciate it.
> [...]
>
> I was working on an alternate interface that would use the existing
> structure and ioctls. There are at least two drivers (cxgb3 and sfc)
> that already do this, though they currently pack PRTAD and DEVAD
> differently in the phy_id field.
I can use the same approach and overload the CL22 definitions, but don't
you think it is cleaner to add the CL45 definition? I think that the
fact that two drivers are already overloading the CL22 for CL45 usage is
showing that CL45 is needed, and the fact that they are doing that
differently shows that there is a need for a clean definition. I'm just
thinking about someone trying to write an application for all CL45
supporting drivers - it is easier if there is a clean interface.
What do you say?
Thanks,
Eilon
next prev parent reply other threads:[~2009-04-30 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 10:08 [RFC] Add clause 45 ioctl Eilon Greenstein
2009-04-28 13:22 ` Ben Hutchings
2009-04-30 15:05 ` Eilon Greenstein [this message]
2009-04-30 15:49 ` Ben Hutchings
2009-04-30 16:21 ` Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241103959.10391.3.camel@lb-tlvb-eliezer \
--to=eilong@broadcom.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yaniv.rosner@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox