From: Jesper Dangaard Brouer <hawk@comx.dk>
To: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"David S. Miller" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"Ronciak, John" <john.ronciak@intel.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Subject: [PATCH 0/2] igb: drop stats due to OS cannot keep up
Date: Thu, 07 May 2009 15:35:46 +0200 [thread overview]
Message-ID: <1241703346.18487.22.camel@localhost.localdomain> (raw)
The following patchset address "drop" stats counters in the igb
driver (chips 82576 and 82575). The drop stats addressed here
are due to the OS cannot keep up.
I have only tested it for the 82576 chip, as my (12 port) 82575
chip based NIC from Hotlava Systems recently died in my testlab :-(((
[First patch]
Implements reading of the per queue drop stats.
These stats only gets incremented if the DROP_EN bit it set (in
the SRRCTL register for that queue, or QDE reg is set).
[Second patch]
Address the case where the DROP_EN it NOT set. In
this case a global register records the equivalent drop type. And
aggregation of these two types of drops into the device net_stats.
I strongly believe that these drops counters should be made
available to sysadm's through the normal device stats. These
stats are essential when diagnosing server performance issues, as
these stats are due to the OS cannot keep up. I strongly believe
that it should be stored in the net_stats rx_fifo_errors counter,
to indicate performance issues.
--
Med venlig hilsen / Best regards
Jesper Brouer
ComX Networks A/S
Linux Network developer
Cand. Scient Datalog / MSc.
Author of http://adsl-optimizer.dk
LinkedIn: http://www.linkedin.com/in/brouer
next reply other threads:[~2009-05-07 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 13:35 Jesper Dangaard Brouer [this message]
2009-05-07 13:37 ` [PATCH 1/2] igb: Implement reading of reg RQDPC (Receive Queue Drop Packet Count) Jesper Dangaard Brouer
2009-05-07 16:06 ` Williams, Mitch A
2009-05-07 19:19 ` Jesper Dangaard Brouer
2009-05-07 19:24 ` Stephen Hemminger
2009-05-11 9:50 ` Jesper Dangaard Brouer
2009-05-13 21:07 ` Williams, Mitch A
2009-05-14 8:03 ` Jesper Dangaard Brouer
2009-05-07 13:38 ` [PATCH 2/2] igb: Record host memory receive overflow in net_stats Jesper Dangaard Brouer
2009-05-14 22:43 ` [PATCH 0/2] igb: drop stats due to OS cannot keep up Jeff Kirsher
2009-05-15 7:41 ` Jesper Dangaard Brouer
2009-05-18 7:16 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241703346.18487.22.camel@localhost.localdomain \
--to=hawk@comx.dk \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).