netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hong H. Pham" <hong.pham@windriver.com>
To: netdev@vger.kernel.org
Cc: "Hong H. Pham" <hong.pham@windriver.com>
Subject: [PATCH 1/1] NIU: fix spurious interrupts
Date: Mon, 11 May 2009 15:00:53 -0400	[thread overview]
Message-ID: <1242068453-5124-2-git-send-email-hong.pham@windriver.com> (raw)
In-Reply-To: <1242068453-5124-1-git-send-email-hong.pham@windriver.com>

It's possible for an interrupt to be triggered while NAPI is in progress
(at least on a SPARC64 SUN4V system).  Unconditionally call
__niu_fastpath_interrupt() in niu_schedule_napi() to mask out the logical
device being serviced to avoid further spurious interrupts from being
generated.

Signed-off-by: Hong H. Pham <hong.pham@windriver.com>
---
 drivers/net/niu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 2b17453..80d4fb6 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -4221,11 +4221,11 @@ static void niu_schedule_napi(struct niu *np, struct niu_ldg *lp,
 	if (likely(napi_schedule_prep(&lp->napi))) {
 		lp->v0 = v0;
 		lp->v1 = v1;
 		lp->v2 = v2;
-		__niu_fastpath_interrupt(np, lp->ldg_num, v0);
 		__napi_schedule(&lp->napi);
 	}
+	__niu_fastpath_interrupt(np, lp->ldg_num, v0);
 }
 
 static irqreturn_t niu_interrupt(int irq, void *dev_id)
 {
-- 
1.6.0.3


  reply	other threads:[~2009-05-11 19:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 19:00 [PATCH 0/1] NIU: fix spurious interrupts Hong H. Pham
2009-05-11 19:00 ` Hong H. Pham [this message]
2009-05-19  5:09 ` David Miller
2009-05-19 21:52   ` Hong H. Pham
2009-05-19 22:01     ` David Miller
2009-05-20 15:57       ` Hong H. Pham
2009-05-21  0:37         ` David Miller
2009-05-21 22:18         ` David Miller
2009-05-22  0:40           ` Hong H. Pham
2009-05-22  8:08             ` David Miller
2009-05-22 16:42               ` Hong H. Pham
2009-05-26  6:16                 ` David Miller
2009-05-27 16:29                   ` Hong H. Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242068453-5124-2-git-send-email-hong.pham@windriver.com \
    --to=hong.pham@windriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).