netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Pull request: bluetooth-2.6 2009-05-11
Date: Mon, 11 May 2009 20:06:54 -0700	[thread overview]
Message-ID: <1242097614.2970.12.camel@localhost.localdomain> (raw)

Hi Dave,

unfortunately I do have three more patches for the 2.6.30 release. The
guys from Nokia are heavily testing this release to make sure that even
the smallest regression or race condition is reported and fixed. And I
am thankful for this since some of these cases only happen with specific
devices out in the market. And while I own a lot of Bluetooth devices,
it is only a small portion :)

We do have a broken module reference counting that got introduced when
trying to fix a lifetime issue with the hci_dev structure. It races
against the sysfs handling inside the work queue. To fix this, split the
reference counting and let the work queue task hold its own.

We call hci_acl_connect_cancel() for an incoming connection. That is
just wrong since their is nothing to cancel. Incoming connections can be
either accepted or reject. Once accepted, their is nothing to cancel.
Only a disconnect would be working.

The security mode 3 with legacy devices triggered another regression
with the pairing timeout. So only use the pairing timeout if the
connection is fully connected. In the security mode 3 the pairing
happens between the connection attempt and completion. And that phase
uses a proper timeout already, so no need to add extra code for special
pairing timeout handling.

Regards

Marcel


Please pull from

    git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git master

This will update the following files:

 net/bluetooth/hci_conn.c  |    6 +++---
 net/bluetooth/hci_event.c |    2 +-
 net/bluetooth/hci_sysfs.c |    3 +++
 3 files changed, 7 insertions(+), 4 deletions(-)

through these ChangeSets:

Marcel Holtmann (3):
    Bluetooth: Fix wrong module refcount when connection setup fails
    Bluetooth: Don't use hci_acl_connect_cancel() for incoming connections
    Bluetooth: Don't trigger disconnect timeout for security mode 3 pairing




             reply	other threads:[~2009-05-12  3:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-12  3:06 Marcel Holtmann [this message]
2009-05-16 20:46 ` Pull request: bluetooth-2.6 2009-05-11 David Miller
2009-05-16 22:32   ` Marcel Holtmann
2009-05-17  5:36     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242097614.2970.12.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).