Re: [PATCH v2 0/7] can: CAN network device driver interface and drivers

[Subrata Modak <subrata@linux.vnet.ibm.com>]

Hi Oliver,

On Tue, 2009-05-12 at 12:46 +0200, Oliver Hartkopp wrote:
> Wolfgang Grandegger wrote:
> > Subrata Modak wrote:
> >> Hi Oliver/Wolfgang,
> >>
> >>> Hello,
> >>>
> >>> here comes v2 of the patch series posted some time ago. See
> >>>
> >>>  http://marc.info/?l=linux-netdev&m=123507025810612&w=4.
> >>>
> >>> Changes since v1:
> > [...]
> >> Would you also like to send a patch to update the testcases for CAN in LTP
> >> (http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/network/can/filter-tests/) ?
> >> These tests were originally picked up from:
> >> http://svn.berlios.de/wsvn/socketcan/trunk/test/?rev=877&sc=1
> >
> > The existing tests uses the vcan (virtual CAN) driver, which is not
> > affected by these patches. Are you thinking about tests using *real* CAN
> > devices?
> >
> 
> Hi Subrata,
> 
> indeed extending the test-cases to the real CAN drivers would urge you 
> to add a least
> two hardware CAN-interfaces to your test system and wire them correctly 
> with the
> appropriate termination.
> It's like having *all* ethernet cards available in your linux box to 
> test them ;-)
> Some of these CAN controllers are only available as an on-chip device
> (e.g. for some PowerPC CPUs).

That makes great sense, as our team uses PowerPC heavily as their test
hardware.

I would also like to have tests added to LTP even if i myself do not
have the hardware to test it. If there´s something of significant
importance to a group of people/community, for which tests need to
exist, then they can make into LTP, provided you have tested them and
Acked them, and somebody else has not complained of any build/run
breaks.

> 
> If there is some room for LTP improvements, i would tend to create some 
> more test-cases
> for the networklayer stuff in linux/net/can using the existent virtual 
> CAN driver.

Please go ahead.

Regards--
Subrata

> 
> Best regards,
> Oliver
>