From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pascal Terjan Subject: Re: SiS 191 failure with MTU > 1496 Date: Tue, 02 Jun 2009 16:14:44 +0200 Message-ID: <1243952084.19053.111.camel@plop> References: <1243615486.12871.44.camel@plop> <1243615800.12871.45.camel@plop> <1243616449.12871.49.camel@plop> <20090529223047.GA29073@electric-eye.fr.zoreil.com> <1243943449.19053.96.camel@plop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org To: Francois Romieu Return-path: Received: from ryu.zarb.org ([212.85.158.22]:53176 "EHLO ryu.zarb.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751960AbZFBOOo (ORCPT ); Tue, 2 Jun 2009 10:14:44 -0400 In-Reply-To: <1243943449.19053.96.camel@plop> Sender: netdev-owner@vger.kernel.org List-ID: Le mardi 02 juin 2009 =E0 13:50 +0200, Pascal Terjan a =E9crit : > Le samedi 30 mai 2009 =E0 00:30 +0200, Francois Romieu a =E9crit : > > Pascal Terjan : > > [...] > > > Oh and even > > > http://bugzilla.kernel.org/show_bug.cgi?id=3D10694 > >=20 > > Yes, it sucks. > >=20 > > > Should I add some info there ? > >=20 > > Not yet but could you retry with RX_BUF_SIZE set to 1544, > > 1528 and 1520 ? > >=20 >=20 > 1544, 1528 and 1520 fail the same way By the way there is some strange code: tp->rx_buf_sz =3D (mtu > RX_BUF_SIZE) ? mtu + ETH_HLEN + 8 : RX_BUF_SIZ= E; Isn't there a (different from the one I'm interested in :) ) bug when 1500 < mtu <=3D RX_BUF_SIZE Shouldn't the test be (mtu > ETH_DATA_LEN) ?