* [PATCH]vxge-config.c: no need for check
@ 2009-06-10 14:21 Figo.zhang
2009-06-11 9:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Figo.zhang @ 2009-06-10 14:21 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
vfree() does its own 'NULL' check, so no need for check before
calling it.
Signed-off-by: Figo.zhang <figo1802@gmail.com>
---
drivers/net/vxge/vxge-config.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/net/vxge/vxge-config.c b/drivers/net/vxge/vxge-config.c
index 6b41c88..26cde57 100644
--- a/drivers/net/vxge/vxge-config.c
+++ b/drivers/net/vxge/vxge-config.c
@@ -1884,17 +1884,13 @@ void __vxge_hw_mempool_destroy(struct vxge_hw_mempool *mempool)
mempool->memblock_size, dma_object);
}
- if (mempool->items_arr)
- vfree(mempool->items_arr);
+ vfree(mempool->items_arr);
- if (mempool->memblocks_dma_arr)
- vfree(mempool->memblocks_dma_arr);
+ vfree(mempool->memblocks_dma_arr);
- if (mempool->memblocks_priv_arr)
- vfree(mempool->memblocks_priv_arr);
+ vfree(mempool->memblocks_priv_arr);
- if (mempool->memblocks_arr)
- vfree(mempool->memblocks_arr);
+ vfree(mempool->memblocks_arr);
vfree(mempool);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]vxge-config.c: no need for check
2009-06-10 14:21 [PATCH]vxge-config.c: no need for check Figo.zhang
@ 2009-06-11 9:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-06-11 9:51 UTC (permalink / raw)
To: figo1802; +Cc: netdev
From: "Figo.zhang" <figo1802@gmail.com>
Date: Wed, 10 Jun 2009 22:21:55 +0800
> vfree() does its own 'NULL' check, so no need for check before
> calling it.
>
> Signed-off-by: Figo.zhang <figo1802@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-11 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 14:21 [PATCH]vxge-config.c: no need for check Figo.zhang
2009-06-11 9:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).