netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* 8139cp vs 8139too, request_module ?
@ 2009-06-10 16:02 Pascal Terjan
  2009-06-10 17:00 ` Ben Hutchings
  0 siblings, 1 reply; 2+ messages in thread
From: Pascal Terjan @ 2009-06-10 16:02 UTC (permalink / raw)
  To: netdev

Hello,
8139cp and 8139too both handle the same id and then test revision.

If revision is wrong they tell to load the other module and return
ENODEV.

Why not doing a request_module instead of printing a message ? 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 8139cp vs 8139too, request_module ?
  2009-06-10 16:02 8139cp vs 8139too, request_module ? Pascal Terjan
@ 2009-06-10 17:00 ` Ben Hutchings
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2009-06-10 17:00 UTC (permalink / raw)
  To: Pascal Terjan; +Cc: netdev

On Wed, 2009-06-10 at 18:02 +0200, Pascal Terjan wrote:
> Hello,
> 8139cp and 8139too both handle the same id and then test revision.
> 
> If revision is wrong they tell to load the other module and return
> ENODEV.
> 
> Why not doing a request_module instead of printing a message ? 

The kernel requests a module to handle each PCI device it doesn't
already have a driver for.  modprobe will then load all modules that
match that PCI device and vendor id.  So 8139cp and 8139too are both
loaded for PCI devices that might be handled by either.  There is no
need for them to try to load each other, and  I suspect there would be a
risk of deadlock if they did.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-06-10 17:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 16:02 8139cp vs 8139too, request_module ? Pascal Terjan
2009-06-10 17:00 ` Ben Hutchings

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).