Re: [RFC usbnet.c] - Add packet aggregation capability

[David Hollis <dhollis@davehollis.com>]

On Thu, 2009-06-11 at 05:38 -0700, David Miller wrote:
> From: David Hollis <dhollis@davehollis.com>
> Date: Wed, 10 Jun 2009 13:57:39 -0400
> 
> > One item that I have is how to handle the portion in usbnet_probe() that
> > sets the hard_start_xmit handler with the change to netdevice_ops:
> > 
> > -	net->hard_start_xmit = usbnet_start_xmit;
> > +	if (info->tx_gather)
> > +		net->hard_start_xmit = usbnet_bundle_xmit;
> > +	else
> > +		net->hard_start_xmit = usbnet_start_xmit;
> > 
> > 
> > Would it be the most appropriate to merge the
> > usbnet_aggregate_skb_xmit() pieces into the existing usbnet_start_xmit
> > with appropriate conditionals?
> 
> In the current tree you cannot even make this assignment.
> 
> Everything must go through a net_device_ops set of methods,
> the pointer of which is const.

So I'd need to have to separate net_device_ops and set
net->hard_start_xmit to the appropriate one based on info->tx_gather
being defined.

Not a problem.


> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html