From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 0/3] netfilter: Use pr_ and pr_fmt Date: Thu, 11 Jun 2009 10:44:59 -0700 Message-ID: <1244742299.30185.7.camel@Joe-Laptop.home> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Patrick McHardy , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, David Miller To: Jan Engelhardt Return-path: In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 2009-06-11 at 13:04 +0200, Jan Engelhardt wrote: > On Thursday 2009-06-11 09:40, Joe Perches wrote: > > >Many of the [wretched grammar removed] netfilter printk > >calls do not have KERN_ prefixes. [] > >Remove the function names in printk strings and add > >#define pr_fmt(fmt) "%s:%s " fmt, KBUILD_MODNAME, __func__ > > Hm I had wished there was a better way than to replicate > this define over all Netfilter files. > Perhaps stuff it into an include. Maybe standardize the netfilter includes a bit later? Patrick, is this patch set concept acceptable at all?