From: "Michael Chan" <mchan@broadcom.com>
To: "Randy Dunlap" <randy.dunlap@oracle.com>
Cc: Netdev <netdev@vger.kernel.org>, "David Miller" <davem@davemloft.net>
Subject: Re: [PATCH -next] cnic: fix build for INET=n or IPV6=m
Date: Fri, 12 Jun 2009 11:04:54 -0700 [thread overview]
Message-ID: <1244829894.9225.63.camel@HP1> (raw)
In-Reply-To: <4A3293E9.7020204@oracle.com>
On Fri, 2009-06-12 at 10:44 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix cnic build for case of CONFIG_INET=n.
> Fix cnic build for case of CONFIG_IPV6=m and CONFIG_CNIC=y.
>
> Fixes these build errors (from different builds):
>
> cnic.c:(.text+0x236a1d): undefined reference to `ip_route_output_key'
> cnic.c:(.text+0x15a8e8): undefined reference to `ip6_route_output'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Michael Chan <mchan@broadcom.com>
Thanks.
> ---
> drivers/net/cnic.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> --- linux-next-20090612.orig/drivers/net/cnic.c
> +++ linux-next-20090612/drivers/net/cnic.c
> @@ -1454,6 +1454,7 @@ static inline u16 cnic_get_vlan(struct n
> static int cnic_get_v4_route(struct sockaddr_in *dst_addr,
> struct dst_entry **dst)
> {
> +#if defined(CONFIG_INET)
> struct flowi fl;
> int err;
> struct rtable *rt;
> @@ -1465,12 +1466,15 @@ static int cnic_get_v4_route(struct sock
> if (!err)
> *dst = &rt->u.dst;
> return err;
> +#else
> + return -ENETUNREACH;
> +#endif
> }
>
> static int cnic_get_v6_route(struct sockaddr_in6 *dst_addr,
> struct dst_entry **dst)
> {
> -#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
> +#if defined(CONFIG_IPV6) || (defined(CONFIG_IPV6_MODULE) && defined(MODULE))
> struct flowi fl;
>
> memset(&fl, 0, sizeof(fl));
> @@ -1550,7 +1554,7 @@ static int cnic_get_route(struct cnic_so
> clear_bit(SK_F_IPV6, &csk->flags);
>
> if (is_v6) {
> -#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
> +#if defined(CONFIG_IPV6) || (defined(CONFIG_IPV6_MODULE) && defined(MODULE))
> set_bit(SK_F_IPV6, &csk->flags);
> err = cnic_get_v6_route(&saddr->remote.v6, &dst);
> if (err)
>
prev parent reply other threads:[~2009-06-12 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 17:44 [PATCH -next] cnic: fix build for INET=n or IPV6=m Randy Dunlap
2009-06-12 18:04 ` Michael Chan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244829894.9225.63.camel@HP1 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).